Date: Fri, 2 Aug 2013 07:56:37 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Antoine Brodin <antoine@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r324150 - head/astro/aa Message-ID: <20130802075637.GA25222@FreeBSD.org> In-Reply-To: <20130802075101.GB18976@ithaqua.etoilebsd.net> References: <201308020748.r727m8hd036121@svn.freebsd.org> <20130802075101.GB18976@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 02, 2013 at 09:51:01AM +0200, Baptiste Daroussin wrote: > On Fri, Aug 02, 2013 at 07:48:08AM +0000, Antoine Brodin wrote: > > Author: antoine > > Date: Fri Aug 2 07:48:07 2013 > > New Revision: 324150 > > URL: http://svnweb.freebsd.org/changeset/ports/324150 > > > > Log: > > Fix without gcc > > [...] > > - @${REINPLACE_CMD} 's|CFLAGS= -O2|CFLAGS+=|' ${WRKSRC}/makefile > > + @${REINPLACE_CMD} 's|CFLAGS= -O2|CFLAGS+=| ; s|CC=|CC?=|' ${WRKSRC}/makefile > > Why not using MAKE_ARGS= CC=${CC} here? > That is how make(1) is designed to work, All variable are always > overwritable by args, ?= is only to allow to overwrite from env. :-) I've started to write similar letter (and in fact, Antoine did not fix numerous other bugs in this port), but decided I better just do it myself in subsequent commit. Working on it now... ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130802075637.GA25222>