Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Aug 2019 16:09:06 -0600
From:      Ian Lepore <ian@freebsd.org>
To:        Mateusz Guzik <mjguzik@gmail.com>, Oliver Pinter <oliver.pinter@hardenedbsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r351471 - in head/sys: kern sys
Message-ID:  <6035df87490ebb7429f76d57a3a5d33e86c06b56.camel@freebsd.org>
In-Reply-To: <CAGudoHG8%2BrnK8j8BwD5HA6CyGoXMyipu0=upXYsuaKJV7-wcXQ@mail.gmail.com>
References:  <201908250511.x7P5BiPl016074@repo.freebsd.org> <CAPQ4fftD57MXX8BpJB2RxNBdR2Ur144mSkB=nMiyFJU4KDs0=w@mail.gmail.com> <CAGudoHG8%2BrnK8j8BwD5HA6CyGoXMyipu0=upXYsuaKJV7-wcXQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2019-08-31 at 00:03 +0200, Mateusz Guzik wrote:
> On 8/25/19, Oliver Pinter <oliver.pinter@hardenedbsd.org> wrote:
> > On Sunday, August 25, 2019, Mateusz Guzik <mjg@freebsd.org> wrote:
> > 
> > > Author: mjg
> > > Date: Sun Aug 25 05:11:43 2019
> > > New Revision: 351471
> > > URL: https://svnweb.freebsd.org/changeset/base/351471
> > > 
> > > Log:
> > >   vfs: add vholdnz (for already held vnodes)
> > 
> > 
> > Why?
> > 
> > (Yes, is can read the real reason in phabricator, but the
> > phabricator
> > didn't considered a persistent information in relation to commit
> > message.
> > Review helper tool just comes and goes as time goes forward, but
> > commit
> > messages survives the repo conversions to other VCS...)
> > 
> > And once you have taken the time to write a correct description in
> > phabricator, it would be really really nice and helpful if you
> > would copy
> > them into commit message.
> > 
> 
> I think it's a fair point that if I included this info in the review
> it
> should make it's way into the commit message.
> 

When I open a new phab review, I specifically write the one-line
summary and text that follows with the idea that I'm going to cut and
paste that exact text as the commit message (mostly because it's easier
to just write all that stuff once).  If there are things I want to say
there that don't make sense for the commit I typically add them as a
separate comment right after I open the initial review.

-- Ian




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6035df87490ebb7429f76d57a3a5d33e86c06b56.camel>