Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Feb 2021 14:14:58 +0000 (UTC)
From:      =?UTF-8?Q?Fernando_Apestegu=c3=ada?= <fernape@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r566474 - in head/devel/newt: . files
Message-ID:  <202102241414.11OEEwow040021@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: fernape
Date: Wed Feb 24 14:14:58 2021
New Revision: 566474
URL: https://svnweb.freebsd.org/changeset/ports/566474

Log:
  devel/newt: does not register shared libs
  
  pkg info -b newt does not show any shared libraries despite the port installing
  one.
  
  The framework uses the output of readelf -d to know if the library has a SONAME
  and this ports does not add a SONAME if it does not detect the GNU linker. Then,
  the resulting package does not register any shared libraries.
  
  * Patch configure.ac to learn and detect LLVM linker so it adds the SONAME to
    the library.
  * Add USE_LDCONFIG (portlint wrongly complains about not installing shared libs)
  
  PR:     253712
  Submitted by:   masamory7@gmail.com
  MFH:	2021Q1

Added:
  head/devel/newt/files/patch-configure.ac   (contents, props changed)
Modified:
  head/devel/newt/Makefile

Modified: head/devel/newt/Makefile
==============================================================================
--- head/devel/newt/Makefile	Wed Feb 24 12:43:54 2021	(r566473)
+++ head/devel/newt/Makefile	Wed Feb 24 14:14:58 2021	(r566474)
@@ -2,7 +2,7 @@
 
 PORTNAME=	newt
 PORTVERSION=	0.52.20
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	devel
 MASTER_SITES=	https://releases.pagure.org/newt/
 
@@ -15,7 +15,7 @@ LICENSE_FILE=	${WRKSRC}/COPYING
 LIB_DEPENDS=	libslang.so:devel/libslang2 \
 		libpopt.so:devel/popt
 
-USES=		gmake ncurses pathfix
+USES=		autoreconf gmake localbase ncurses pathfix
 GNU_CONFIGURE=	yes
 MAKE_ENV=	PCFLAGS="${CFLAGS}"
 USE_LDCONFIG=	yes
@@ -46,10 +46,8 @@ TCL_CPPFLAGS=		-I${TCL_INCLUDEDIR:Q}
 SOVERSION=	${PORTVERSION:R:E}
 
 post-patch:
+	@${REINPLACE_CMD} -e 's|-DUSE_INTERP_RESULT||' ${WRKSRC}/configure.ac
 	@${REINPLACE_CMD} -e \
-		'/^SONAME/s|=.*|=${SOVERSION}| ; \
-		 s|-DUSE_INTERP_RESULT||' ${WRKSRC}/configure
-	@${REINPLACE_CMD} -e \
 		's|@CPP@|@CC@ -E| ; \
 		 s|-D_GNU_SOURCE|| ; \
 		 s| -g | |g ; \
@@ -58,7 +56,7 @@ post-patch:
 
 post-patch-PYTHON-on:
 	@${REINPLACE_CMD} -e \
-		'/PYTHONVERS/s|=.*|=${PYTHON_VERSION}|' ${WRKSRC}/configure
+		'/PYTHONVERS/s|=.*|=${PYTHON_VERSION}|' ${WRKSRC}/configure.ac
 
 post-install:
 	@${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/whiptail

Added: head/devel/newt/files/patch-configure.ac
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/devel/newt/files/patch-configure.ac	Wed Feb 24 14:14:58 2021	(r566474)
@@ -0,0 +1,29 @@
+--- configure.ac.orig	2017-03-17 10:36:31 UTC
++++ configure.ac
+@@ -2,7 +2,7 @@ AC_INIT([newt_pr.h])
+ 
+ PACKAGE=newt
+ VERSION=0.52.20
+-SONAME=0.52
++SONAME=52
+ 
+ AC_CONFIG_HEADER([config.h])
+ 
+@@ -24,7 +24,7 @@ AC_CHECK_SIZEOF([void *])
+ AC_MSG_CHECKING([for GNU ld])
+ LD=`$CC -print-prog-name=ld 2>&5`
+ 
+-if test `$LD -v 2>&1 | $ac_cv_path_GREP -c "GNU ld"` = 0; then
++if test `$LD -v 2>&1 | $ac_cv_path_GREP -c -E "GNU ld|compatible with GNU linkers"` = 0; then
+   # Not
+   GNU_LD=""
+   AC_MSG_RESULT([no])
+@@ -102,7 +102,7 @@ else
+     AC_SUBST([TCL_LIB_FLAG])
+     WHIPTCLLIB=whiptcl
+     # needed with tcl8.6
+-    CPPFLAGS="$CPPFLAGS -DUSE_INTERP_RESULT"
++    CPPFLAGS="$CPPFLAGS "
+   else
+     AC_MSG_RESULT([NOT found])
+   fi



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202102241414.11OEEwow040021>