Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 20 Jun 2013 17:55:43 +0200
From:      nemysis <nemysis@gmx.ch>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        ericturgeon@ghostbsd.org
Subject:   ports/179775: [PATCH] audio/lxmusic: 
Message-ID:  <20130620155546.CE0EF16E@hub.freebsd.org>
Resent-Message-ID: <201306201600.r5KG004c064337@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         179775
>Category:       ports
>Synopsis:       [PATCH] audio/lxmusic:
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 20 16:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     nemysis
>Release:        FreeBSD 9.1-RELEASE-p8 amd64
>Organization:
>Environment:
System: FreeBSD FreeBSD_Ports 9.1-RELEASE-p8 FreeBSD 9.1-RELEASE-p8 #0: Tue Jun 18 15:25:28 UTC 2013
>Description:

- Trim Makefile header
- Add license (MIT GPLv2)
- Add desktop dependency
- Add docs
- Add NLS Option
- Fix NLS
- Trim pkg-plist

Port maintainer (ericturgeon@ghostbsd.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_7 (mode: change, diff: ports)
>How-To-Repeat:

Build log

https://redports.org/buildarchive/20130620145100-63721/

>Fix:

--- lxmusic-0.4.5.patch begins here ---
diff -ruN /usr/ports/audio/lxmusic/Makefile ./Makefile
--- /usr/ports/audio/lxmusic/Makefile	2013-06-02 19:00:40.000000000 +0200
+++ ./Makefile	2013-06-20 17:45:44.000000000 +0200
@@ -1,3 +1,4 @@
+# Created by: Eric Turgeon <ericturgeon.bsd at gmail.com>
 # $FreeBSD: head/audio/lxmusic/Makefile 316464 2013-04-24 18:10:30Z ak $
 
 PORTNAME=	lxmusic
@@ -8,18 +9,46 @@
 MAINTAINER=	ericturgeon@ghostbsd.org
 COMMENT=	LXDE music player based on xmms2
 
+LICENSE=	MIT GPLv2
+LICENSE_COMB=	dual
+
 LIB_DEPENDS=	xmmsclient:${PORTSDIR}/audio/xmms2 \
 		notify:${PORTSDIR}/devel/libnotify
 
+USES=		desktop-file-utils
 USE_GNOME=	gtk20
-USE_GMAKE=	yes
 GNU_CONFIGURE=	yes
-USES=		gettext
+USE_GMAKE=	yes
 INSTALLS_ICONS=	yes
+
 CPPFLAGS+=	-I${LOCALBASE}/include ${PTHREAD_CFLAGS}
 LDFLAGS+=	-L${LOCALBASE}/lib ${PTHREAD_LIBS}
 
+PORTDOCS=	AUTHORS README
+
+OPTIONS_DEFINE=	NLS
+
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MNLS}
+USES+=		gettext
+PLIST_SUB+=	NLS=""
+.else
+CONFIGURE_ARGS+=--disable-nls
+PLIST_SUB+=	NLS="@comment "
+.endif
+
+post-patch:
+.if ! ${PORT_OPTIONS:MNLS}
+	@${REINPLACE_CMD} -e 's|data po|data|' \
+		${WRKSRC}/Makefile.in
+
+.endif
+
 post-install:
-	@-${LOCALBASE}/bin/update-desktop-database > /dev/null
+.if ${PORT_OPTIONS:MDOCS}
+	@${MKDIR} ${DOCSDIR}
+	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR}
+.endif
 
 .include <bsd.port.mk>
diff -ruN /usr/ports/audio/lxmusic/pkg-plist ./pkg-plist
--- /usr/ports/audio/lxmusic/pkg-plist	2013-06-02 19:00:40.000000000 +0200
+++ ./pkg-plist	2013-06-20 16:48:50.000000000 +0200
@@ -1,64 +1,62 @@
 bin/lxmusic
 share/applications/lxmusic.desktop
-share/locale/af/LC_MESSAGES/lxmusic.mo
-share/locale/ar/LC_MESSAGES/lxmusic.mo
-share/locale/bg/LC_MESSAGES/lxmusic.mo
-share/locale/bn_IN/LC_MESSAGES/lxmusic.mo
-share/locale/ca/LC_MESSAGES/lxmusic.mo
-share/locale/cs/LC_MESSAGES/lxmusic.mo
-share/locale/da/LC_MESSAGES/lxmusic.mo
-share/locale/de/LC_MESSAGES/lxmusic.mo
-share/locale/el/LC_MESSAGES/lxmusic.mo
-share/locale/es/LC_MESSAGES/lxmusic.mo
-share/locale/es_VE/LC_MESSAGES/lxmusic.mo
-share/locale/et/LC_MESSAGES/lxmusic.mo
-share/locale/eu/LC_MESSAGES/lxmusic.mo
-share/locale/fa/LC_MESSAGES/lxmusic.mo
-share/locale/fi/LC_MESSAGES/lxmusic.mo
-share/locale/fr/LC_MESSAGES/lxmusic.mo
-share/locale/frp/LC_MESSAGES/lxmusic.mo
-share/locale/gl/LC_MESSAGES/lxmusic.mo
-share/locale/he/LC_MESSAGES/lxmusic.mo
-share/locale/hr/LC_MESSAGES/lxmusic.mo
-share/locale/hu/LC_MESSAGES/lxmusic.mo
-share/locale/id/LC_MESSAGES/lxmusic.mo
-share/locale/it/LC_MESSAGES/lxmusic.mo
-share/locale/ja/LC_MESSAGES/lxmusic.mo
-share/locale/ko/LC_MESSAGES/lxmusic.mo
-share/locale/lt/LC_MESSAGES/lxmusic.mo
-share/locale/ml/LC_MESSAGES/lxmusic.mo
-share/locale/ms/LC_MESSAGES/lxmusic.mo
-share/locale/nb/LC_MESSAGES/lxmusic.mo
-share/locale/nl/LC_MESSAGES/lxmusic.mo
-share/locale/nn/LC_MESSAGES/lxmusic.mo
-share/locale/pl/LC_MESSAGES/lxmusic.mo
-share/locale/ps/LC_MESSAGES/lxmusic.mo
-share/locale/pt/LC_MESSAGES/lxmusic.mo
-share/locale/pt_BR/LC_MESSAGES/lxmusic.mo
-share/locale/ru/LC_MESSAGES/lxmusic.mo
-share/locale/sk/LC_MESSAGES/lxmusic.mo
-share/locale/sl/LC_MESSAGES/lxmusic.mo
-share/locale/sr/LC_MESSAGES/lxmusic.mo
-share/locale/sv/LC_MESSAGES/lxmusic.mo
-share/locale/tr/LC_MESSAGES/lxmusic.mo
-share/locale/uk/LC_MESSAGES/lxmusic.mo
-share/locale/ur/LC_MESSAGES/lxmusic.mo
-share/locale/ur_PK/LC_MESSAGES/lxmusic.mo
-share/locale/vi/LC_MESSAGES/lxmusic.mo
-share/locale/zh_CN/LC_MESSAGES/lxmusic.mo
-share/locale/zh_TW/LC_MESSAGES/lxmusic.mo
-share/lxmusic/lxmusic.ui.glade
-share/lxmusic/popup.ui.glade
-share/lxmusic/pref-dlg.ui.glade
-share/lxmusic/track-info.ui.glade
+%%NLS%%share/locale/af/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ar/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/bg/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/bn_IN/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ca/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/cs/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/da/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/de/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/el/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/es/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/es_VE/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/et/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/eu/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/fa/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/fi/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/fr/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/frp/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/gl/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/he/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/hr/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/hu/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/id/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/it/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ja/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ko/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/lt/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ml/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ms/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/nb/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/nl/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/nn/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/pl/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ps/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/pt/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/pt_BR/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ru/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/sk/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/sl/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/sr/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/sv/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/tr/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/uk/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ur/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/ur_PK/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/vi/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/zh_CN/LC_MESSAGES/lxmusic.mo
+%%NLS%%share/locale/zh_TW/LC_MESSAGES/lxmusic.mo
+%%DATADIR%%/lxmusic.ui.glade
+%%DATADIR%%/popup.ui.glade
+%%DATADIR%%/pref-dlg.ui.glade
+%%DATADIR%%/track-info.ui.glade
 share/pixmaps/lxmusic.png
-@dirrm share/lxmusic
-@dirrmtry share/locale/ur_PK/LC_MESSAGES
-@dirrmtry share/locale/ur_PK
-@dirrmtry share/locale/frp/LC_MESSAGES
-@dirrmtry share/locale/frp
-@dirrmtry share/locale/es_VE/LC_MESSAGES
-@dirrmtry share/locale/es_VE
+@dirrm %%DATADIR%%
+%%NLS%%@dirrmtry share/locale/ur_PK/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/ur_PK
+%%NLS%%@dirrmtry share/locale/frp/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/frp
+%%NLS%%@dirrmtry share/locale/es_VE/LC_MESSAGES
+%%NLS%%@dirrmtry share/locale/es_VE
 @dirrmtry share/applications
-@exec %%LOCALBASE%%/bin/update-desktop-database > /dev/null || /usr/bin/true
-@unexec %%LOCALBASE%%/bin/update-desktop-database > /dev/null || /usr/bin/true
--- lxmusic-0.4.5.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130620155546.CE0EF16E>