Date: Thu, 8 Jun 2017 08:24:24 +0100 From: Bartek Rutkowski <robak@FreeBSD.org> To: "Sergey A. Osokin" <osa@FreeBSD.org> Cc: Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r442588 - in head/www: nginx nginx-full Message-ID: <A3E03B49-5BE4-4DD2-AB4A-AA0C99A16851@FreeBSD.org> In-Reply-To: <20170607220614.GB55217@FreeBSD.org> References: <201706042038.v54KcQMf001482@repo.freebsd.org> <20170605001807.GA55217@FreeBSD.org> <99D58682-8825-417C-81F8-EDC541D31713@FreeBSD.org> <20170607220614.GB55217@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 7 Jun 2017, at 23:06, Sergey A. Osokin <osa@FreeBSD.org> wrote: >=20 > On Tue, Jun 06, 2017 at 02:32:17PM +0100, Bartek Rutkowski wrote: >>> On 5 Jun 2017, at 01:18, Sergey A. Osokin <osa@FreeBSD.org> wrote: >>>=20 >>> Hi Bartek and Adam, >>>=20 >>> I don't think I can get this, so two questions for you guys: >>> o) what was the reason to bump PORTREVISION in www/nginx? >>> o) wouldn't it btter to just bump PORTREVISION in www/nginx-full? >>=20 >> Hi Sergey, >>=20 >> Let me explain it quickly: some time ago you've removed two external = modules from www/nginx port, which is a master for www/nginx-full. The = www/nginx-full had them in default options, what caused port/pkg build = failures and to fix these I needed to remove these two no longer = existing modules from default options. After doing so, since it *does* = change the contents of the package, I needed to bump the PORTREVISION of = www/nginx-full and there were few ways of doing so, but none of them was = easy/simple as they were creating even complex scenarios in future = bumps/updates, so, after consulting possible solutions with portmgr = members, I've chosen one, that while not ideal, have solved the issue = for now without creating other issues in future, that is to bump the = master www/nginx revision. >>=20 >> Hope that helps. >=20 > Hi Bartek, >=20 > Please don't bump PORTREVISION on www/nginx when you need to do so > in www/nginx-full. Sergey, I tried to explain you why it was necessary - it wasn't my 'oh, I just = want to bump some ports revisions' spree. It was discussed with portmgr = members and approved with adamw@. This is how master/slave relationship = works in our ports and there was no other better way around it. Hope = you'll understand that and accept it in future, where similar action = would be required. Kind regards, Bartek Rutkowski=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A3E03B49-5BE4-4DD2-AB4A-AA0C99A16851>