Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 14 Dec 2008 18:25:00 -0600 (CST)
From:      Dan Nelson <dnelson@allantgroup.com>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/129643: [PATCH] audio/sox; add png OPTION
Message-ID:  <200812150025.mBF0P0G1052841@dan.emsphone.com>
Resent-Message-ID: <200812150050.mBF0o4xb056039@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         129643
>Category:       ports
>Synopsis:       [PATCH] audio/sox; add png OPTION
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 15 00:50:04 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Dan Nelson
>Release:        FreeBSD 7.1-PRERELEASE i386
>Organization:
The Allant Group
>Environment:
System: FreeBSD dan.emsphone.com 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #569: Fri Nov 7 13:25:27 CST 2008 zsh@dan.emsphone.com:/usr/src-7/sys/i386/compile/DANSMP i386


	
>Description:
	

The existing sox port always depends on libpng, but it's only required
for the optional spectogram creation option.  The included path adds an
OPTION to disable it.

>How-To-Repeat:
	
>Fix:

	

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/audio/sox/Makefile,v
retrieving revision 1.41
diff -u -r1.41 Makefile
--- Makefile	15 Nov 2008 18:57:46 -0000	1.41
+++ Makefile	15 Dec 2008 00:23:37 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	sox
 PORTVERSION=	14.2.0
+PORTREVISION=	1
 CATEGORIES=	audio
 MASTER_SITES=	SF
 
@@ -39,6 +40,7 @@
 		LADSPA "Audio plugin support" off \
 		LAME "Enable mp3 encoding with LAME" ${_LAME} \
 		MAD "Enable mp3 decoding with MAD" on \
+		PNG "Enable PNG spectrogram creation" on \
 		SAMPLERATE "Enable libsamplerate" on \
 		SNDFILE "Enable libsndfile" on \
 		VORBIS "Enable Ogg Vorbis support" on \
@@ -50,7 +52,6 @@
 LDFLAGS+=	-L${LOCALBASE}/lib ${PTHREAD_LIBS}
 CONFIGURE_ENV+=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
 CONFIGURE_ARGS+=	--with-pkgconfigdir="${PREFIX}/libdata/pkgconfig"
-LIB_DEPENDS+=	png.5:${PORTSDIR}/graphics/png
 
 .if !defined(WITH_LAME) && !defined(WITH_MAD)
 PLIST_SUB+=	PLIST_MP3="@comment "
@@ -143,6 +144,13 @@
 CONFIGURE_ARGS+=	--without-mad
 .endif
 
+.if defined(WITH_PNG)
+CONFIGURE_ARGS+=       --with-png
+LIB_DEPENDS+=          png.5:${PORTSDIR}/graphics/png
+.else
+CONFIGURE_ARGS+=       --without-png
+.endif
+
 .if defined(WITH_GSM)
 CONFIGURE_ARGS+=	--with-external-gsm
 LIB_DEPENDS+=		gsm.1:${PORTSDIR}/audio/gsm
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812150025.mBF0P0G1052841>