From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Dec 15 00:50:05 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E6B4C1065670 for ; Mon, 15 Dec 2008 00:50:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BB7AC8FC17 for ; Mon, 15 Dec 2008 00:50:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mBF0o4Fn056042 for ; Mon, 15 Dec 2008 00:50:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mBF0o4xb056039; Mon, 15 Dec 2008 00:50:04 GMT (envelope-from gnats) Resent-Date: Mon, 15 Dec 2008 00:50:04 GMT Resent-Message-Id: <200812150050.mBF0o4xb056039@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Nelson Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 78545106564A for ; Mon, 15 Dec 2008 00:42:45 +0000 (UTC) (envelope-from dan@dan.emsphone.com) Received: from email2.allantgroup.com (email2.emsphone.com [199.67.51.116]) by mx1.freebsd.org (Postfix) with ESMTP id F076E8FC1A for ; Mon, 15 Dec 2008 00:42:44 +0000 (UTC) (envelope-from dan@dan.emsphone.com) Received: from dan.emsphone.com (dan-a.emsphone.com [199.67.51.107]) by email2.allantgroup.com (8.14.0/8.14.0) with ESMTP id mBF0P1M8011945 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 14 Dec 2008 18:25:01 -0600 (CST) (envelope-from dan@dan.emsphone.com) Received: from dan.emsphone.com (smmsp@localhost [127.0.0.1]) by dan.emsphone.com (8.14.3/8.14.3) with ESMTP id mBF0P0SA052844 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 14 Dec 2008 18:25:00 -0600 (CST) (envelope-from dan@dan.emsphone.com) Received: (from dan@localhost) by dan.emsphone.com (8.14.3/8.14.3/Submit) id mBF0P0G1052841; Sun, 14 Dec 2008 18:25:00 -0600 (CST) (envelope-from dan) Message-Id: <200812150025.mBF0P0G1052841@dan.emsphone.com> Date: Sun, 14 Dec 2008 18:25:00 -0600 (CST) From: Dan Nelson To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/129643: [PATCH] audio/sox; add png OPTION X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Dec 2008 00:50:05 -0000 >Number: 129643 >Category: ports >Synopsis: [PATCH] audio/sox; add png OPTION >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Mon Dec 15 00:50:04 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Dan Nelson >Release: FreeBSD 7.1-PRERELEASE i386 >Organization: The Allant Group >Environment: System: FreeBSD dan.emsphone.com 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #569: Fri Nov 7 13:25:27 CST 2008 zsh@dan.emsphone.com:/usr/src-7/sys/i386/compile/DANSMP i386 >Description: The existing sox port always depends on libpng, but it's only required for the optional spectogram creation option. The included path adds an OPTION to disable it. >How-To-Repeat: >Fix: Index: Makefile =================================================================== RCS file: /home/ncvs/ports/audio/sox/Makefile,v retrieving revision 1.41 diff -u -r1.41 Makefile --- Makefile 15 Nov 2008 18:57:46 -0000 1.41 +++ Makefile 15 Dec 2008 00:23:37 -0000 @@ -7,6 +7,7 @@ PORTNAME= sox PORTVERSION= 14.2.0 +PORTREVISION= 1 CATEGORIES= audio MASTER_SITES= SF @@ -39,6 +40,7 @@ LADSPA "Audio plugin support" off \ LAME "Enable mp3 encoding with LAME" ${_LAME} \ MAD "Enable mp3 decoding with MAD" on \ + PNG "Enable PNG spectrogram creation" on \ SAMPLERATE "Enable libsamplerate" on \ SNDFILE "Enable libsndfile" on \ VORBIS "Enable Ogg Vorbis support" on \ @@ -50,7 +52,6 @@ LDFLAGS+= -L${LOCALBASE}/lib ${PTHREAD_LIBS} CONFIGURE_ENV+= CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}" CONFIGURE_ARGS+= --with-pkgconfigdir="${PREFIX}/libdata/pkgconfig" -LIB_DEPENDS+= png.5:${PORTSDIR}/graphics/png .if !defined(WITH_LAME) && !defined(WITH_MAD) PLIST_SUB+= PLIST_MP3="@comment " @@ -143,6 +144,13 @@ CONFIGURE_ARGS+= --without-mad .endif +.if defined(WITH_PNG) +CONFIGURE_ARGS+= --with-png +LIB_DEPENDS+= png.5:${PORTSDIR}/graphics/png +.else +CONFIGURE_ARGS+= --without-png +.endif + .if defined(WITH_GSM) CONFIGURE_ARGS+= --with-external-gsm LIB_DEPENDS+= gsm.1:${PORTSDIR}/audio/gsm >Release-Note: >Audit-Trail: >Unformatted: