Date: Fri, 24 Jun 2016 06:33:37 -0600 From: Adam Weinberger <adamw@adamw.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r417374 - in head: Mk Mk/Uses lang/php55 lang/php56 lang/php70 www/redaxo Message-ID: <633619EE-3555-435A-BD17-389F5ED6C6C4@adamw.org> In-Reply-To: <7E036E80F9D532528C3155FB@atuin.in.mat.cc> References: <201606231319.u5NDJILd062527@repo.freebsd.org> <2400E414-B4B4-479C-BE0F-D804F1E0110A@adamw.org> <83BA65E7C58012B7AA8A7962@atuin.in.mat.cc> <307F483A-1ABE-4E02-A268-16F014D8DC44@adamw.org> <7E036E80F9D532528C3155FB@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 24 Jun, 2016, at 1:28, Mathieu Arnold <mat@FreeBSD.org> wrote: >=20 >=20 >=20 > +--On 23 juin 2016 16:37:36 -0600 Adam Weinberger <adamw@adamw.org> = wrote: > |> On 23 Jun, 2016, at 15:36, Mathieu Arnold <mat@FreeBSD.org> wrote: > |>=20 > |> +--On 23 juin 2016 13:46:41 -0600 Adam Weinberger <adamw@adamw.org> > |> wrote: > |> |> On 23 Jun, 2016, at 7:19, Mathieu Arnold <mat@FreeBSD.org> = wrote: > |> |>=20 > |> |> Author: mat > |> |> Date: Thu Jun 23 13:19:17 2016 > |> |> New Revision: 417374 > |> |> URL: https://svnweb.freebsd.org/changeset/ports/417374 > |> |>=20 > |> |> Log: > |> |> Move bsd.php.mk to Uses/php.mk > |> |>=20 > |> |> PR: 210323 > |> |> Submitted by: mat > |> |> Exp-run by: antoine > |> |> Sponsored by: Absolight > |> |> Differential Revision: https://reviews.freebsd.org/D6867 > |> |=20 > |> |> # If you are building PHP-based ports in poudriere(8) with ZTS > |> |> # enabled, add WITH_MPM=3Devent to /etc/make.conf to prevent = build > |> |> # failures. > |> |=20 > |> | Does USES=3Dphp still have the above bug? If not, are there plans = to make > |> | ZTS detection work without assuming that everybody has apache > |> | installed? > |>=20 > |> I did not change a thing, I'm modernizing the framework, I'm = changing how > |> things are done, but not what the things being done do. > |>=20 > |> (Also, I have absolutely no idea what ZTS is, or what the = difference > |> between the different MPM are.) > |=20 > | ZTS is a threading model for PHP. For a long time, bsd.php.mk has = made > | the strange decision to use the output of 'httpd -V' (from apache) = to > | determine whether PHP was built with ZTS. It uses that to determine = which > | directory to put modules into. > |=20 > | The problem with that bizarre method is that if you don't have = apache > | installed, it puts modules into the wrong directory, and then all = further > | builds fail. In order to build PHP ports in poudriere, you have to = trick > | the system by using that WITH_MPM=3Devent line. > |=20 > | There are a couple bugs open about it. 201193 and 207284 are both = open > | for it. php.mk should either put all PHP modules into one place = (there's > | really no point to making the module dir change), or figure out = whether > | PHP was built with ZTS by examining php.ini or the output of = php-config. >=20 > I'll have a look at it, I'm refactoring USES=3Dphp right now[1]. = Though, I'm > more inclined to do baby steps, and not change what's in it. The = directory > could easily be put in the php.conf file, it would solve all those > problems, I think. >=20 > 1: https://reviews.freebsd.org/D6936 That definitely feels like the right place for it. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?633619EE-3555-435A-BD17-389F5ED6C6C4>