From owner-svn-ports-head@freebsd.org Tue Nov 6 13:02:06 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 128D61123232; Tue, 6 Nov 2018 13:02:06 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 714AA759F7; Tue, 6 Nov 2018 13:02:05 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 0FFE1170F2; Tue, 6 Nov 2018 13:02:05 +0000 (UTC) From: Jan Beich To: =?utf-8?Q?T=C4=B3l?= Coosemans Cc: Koichiro Iwao , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r484197 - in head/lang/duktape-lib: . files References: <201811051548.wA5Fmg5G063134@repo.freebsd.org> <20181106130040.75d98989@kalimero.tijl.coosemans.org> Date: Tue, 06 Nov 2018 14:02:00 +0100 In-Reply-To: <20181106130040.75d98989@kalimero.tijl.coosemans.org> (=?utf-8?Q?=22T=C4=B3l?= Coosemans"'s message of "Tue, 6 Nov 2018 13:00:40 +0100") Message-ID: <36se-4awn-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 714AA759F7 X-Spamd-Result: default: False [-103.07 / 200.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; ALLOW_DOMAIN_WHITELIST(-100.00)[freebsd.org]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.97)[-0.974,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[5]; MX_GOOD(-0.01)[cached: mx66.freebsd.org]; NEURAL_HAM_SHORT(-0.99)[-0.991,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 13:02:06 -0000 T=C4=B3l Coosemans writes: > On Mon, 5 Nov 2018 15:48:42 +0000 (UTC) Koichiro Iwao = wrote: > >> Author: meta >> Date: Mon Nov 5 15:48:42 2018 >> New Revision: 484197 >> URL: https://svnweb.freebsd.org/changeset/ports/484197 >>=20 >> Log: >> lang/duktape-lib: Update to 2.3.0 [...] >> - libduktape.so.$(REAL_VERSION): >> -- gcc -shared -fPIC -Wall -Wextra -Os -Wl,-soname,libduktape.so.$(SONAM= E_VERSION) \ >> -+ $(CC) -shared $(CFLAGS) -fPIC -Wall -Wextra -Wl,-soname,libduktape.so= .$(SONAME_VERSION) \ >> - -o $@ $(DUKTAPE_SRCDIR)/duktape.c >> +-CC =3D gcc >> ++CC =3D cc > > If you add 'MAKE_ARGS=3D CC=3D"${CC}"' to the port Makefile you don't need > this patch and it makes the port build on systems where cc doesn't exist. Well, "as is" the port currently fails to respect both CC and CFLAGS. Changing either can be done by user for optimization, debugging or as a workaround. https://www.freebsd.org/doc/en/books/porters-handbook/dads-cc.html https://www.freebsd.org/doc/en/books/porters-handbook/dads-cflags.html