Date: Thu, 25 Aug 2016 14:00:59 +0100 From: Chris Rees <crees@physics.org> To: Mathieu Arnold <mat@FreeBSD.org>, Chris Rees <crees@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r420830 - in head/databases: . neo4j neo4j/files Message-ID: <B9BF4FB6-8199-43B7-8B04-36F296350BA3@physics.org> In-Reply-To: <E517BD68BFD4F4C37851CDEA@ogg.in.absolight.net> References: <201608250219.u7P2JFVf030918@repo.freebsd.org> <117832A4D3327FBB22E27C1A@atuin.in.mat.cc> <6C64CE8A-06BF-48F8-A7B0-B4F7D9552061@physics.org> <E517BD68BFD4F4C37851CDEA@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 25 August 2016 11:40:44 BST, Mathieu Arnold <mat@FreeBSD.org> wrote:
>+--On 25 août 2016 10:11:41 +0100 Chris Rees <crees@physics.org> wrote:
>|
>|
>| On 25 August 2016 09:47:07 BST, Mathieu Arnold <mat@FreeBSD.org>
>wrote:
>|>
>|>
>|> +--On 25 août 2016 02:19:15 +0000 Chris Rees <crees@FreeBSD.org>
>wrote:
>|>| +post-patch:
>|>| + ${REINPLACE_CMD} ${_SUB_LIST_TEMP} ${WRKSRC}/bin/neo4j-shared.sh
>\
>|>| + ${WRKSRC}/conf/neo4j.conf
>|>
>|> _SUB_LIST_TEMP is an undocumented *internal* framework variable. It
>|> should
>|> *never* be used in a port's Makefile.
>|> With the amount of things I'm rewriting, it may disapear any day,
>and I
>|> will not hunt down the ports that use it where they should not.
>|
>| I must say I had a reservation about using it, although I think I've
>seen
>| this done before. I think this should be exposed as
>${SUB_SED_COMMAND}
>| or something because it's useful.
>|
>| Is there a mechanism for having patchfiles as SUB_FILES?
>
>No, it is a bad idea to use sed on patches because it makes running
>make
>makepatch impossible.
>
>It is why everyone uses sed in post-patch to replace the %%foo%% they
>put
>in their patches.
>
>To regenerate your patches, all you then have to do is:
>
>make clean extract do-patch makepatch
>
>(or if USES=dos2unix)
>
>make clean extract dos2unix do-patch makepatch
You will note that this is exactly what I'm doing currently :)
Is there any chance of exposing the regex? If not I'll just copy/paste it into the port.
Chris
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B9BF4FB6-8199-43B7-8B04-36F296350BA3>