From owner-svn-ports-head@freebsd.org Thu Aug 25 13:01:06 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6F05ABC5841; Thu, 25 Aug 2016 13:01:06 +0000 (UTC) (envelope-from crees@physics.org) Received: from mail50c50.megamailservers.eu (mail152c50.megamailservers.eu [91.136.10.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D533D1D1D; Thu, 25 Aug 2016 13:01:03 +0000 (UTC) (envelope-from crees@physics.org) X-Authenticated-User: bayofrum.uwclub.net Received: from pegasus.bayofrum.net (host-2-102-106-111.as13285.net [2.102.106.111]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id u7PD0wew024859; Thu, 25 Aug 2016 13:00:59 +0000 Received: from android-2959dc0305d63573.bayofrum.net (android-2959dc0305d63573.bayofrum.net [192.168.1.104]) by pegasus.bayofrum.net (Postfix) with ESMTPSA id 61397406B; Thu, 25 Aug 2016 14:00:56 +0100 (BST) User-Agent: K-9 Mail for Android In-Reply-To: References: <201608250219.u7P2JFVf030918@repo.freebsd.org> <117832A4D3327FBB22E27C1A@atuin.in.mat.cc> <6C64CE8A-06BF-48F8-A7B0-B4F7D9552061@physics.org> MIME-Version: 1.0 Subject: Re: svn commit: r420830 - in head/databases: . neo4j neo4j/files From: Chris Rees Date: Thu, 25 Aug 2016 14:00:59 +0100 To: Mathieu Arnold , Chris Rees , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: X-bayofrum-MailScanner-Information: Please contact the ISP for more information X-bayofrum-MailScanner-ID: 61397406B.A24AC X-bayofrum-MailScanner: Found to be clean X-bayofrum-MailScanner-From: crees@physics.org X-Spam-Status: No X-CTCH-RefID: str=0001.0A0B0205.57BEEC0C.00BB, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.1 cv=CLATA3bD c=1 sm=1 tr=0 a=gIyif6r13gc5Hj8RuoB4yw==:117 a=gIyif6r13gc5Hj8RuoB4yw==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=7z1cN_iqozsA:10 a=6I5d2MoRAAAA:8 a=YSpJPxIhAAAA:8 a=MDJ4f-mrj3uBcxQlPPsA:9 a=QEXdDO2ut3YA:10 a=tAMoWCdLAAAA:8 a=P0S6o3SJAAAA:8 a=VTv4hCEg65A98E9r:21 a=-FEs8UIgK8oA:10 a=NWVoK91CQyQA:10 a=IjZwj45LgO3ly-622nXo:22 a=TN9YaynplG-IqH6nzZQ2:22 a=afsLMyc-iwLwWtJJIuI_:22 a=WH_0ghv6r2uJcVQkXlWi:22 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2016 13:01:06 -0000 On 25 August 2016 11:40:44 BST, Mathieu Arnold wrote: >+--On 25 août 2016 10:11:41 +0100 Chris Rees wrote: >| >| >| On 25 August 2016 09:47:07 BST, Mathieu Arnold >wrote: >|> >|> >|> +--On 25 août 2016 02:19:15 +0000 Chris Rees >wrote: >|>| +post-patch: >|>| + ${REINPLACE_CMD} ${_SUB_LIST_TEMP} ${WRKSRC}/bin/neo4j-shared.sh >\ >|>| + ${WRKSRC}/conf/neo4j.conf >|> >|> _SUB_LIST_TEMP is an undocumented *internal* framework variable. It >|> should >|> *never* be used in a port's Makefile. >|> With the amount of things I'm rewriting, it may disapear any day, >and I >|> will not hunt down the ports that use it where they should not. >| >| I must say I had a reservation about using it, although I think I've >seen >| this done before. I think this should be exposed as >${SUB_SED_COMMAND} >| or something because it's useful. >| >| Is there a mechanism for having patchfiles as SUB_FILES? > >No, it is a bad idea to use sed on patches because it makes running >make >makepatch impossible. > >It is why everyone uses sed in post-patch to replace the %%foo%% they >put >in their patches. > >To regenerate your patches, all you then have to do is: > >make clean extract do-patch makepatch > >(or if USES=dos2unix) > >make clean extract dos2unix do-patch makepatch You will note that this is exactly what I'm doing currently :) Is there any chance of exposing the regex? If not I'll just copy/paste it into the port. Chris -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.