From owner-svn-src-head@FreeBSD.ORG Mon Aug 25 16:13:44 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 99FE18BA; Mon, 25 Aug 2014 16:13:44 +0000 (UTC) Received: from i3mail.icecube.wisc.edu (i3mail.icecube.wisc.edu [128.104.255.23]) by mx1.freebsd.org (Postfix) with ESMTP id 6BC573C35; Mon, 25 Aug 2014 16:13:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by i3mail.icecube.wisc.edu (Postfix) with ESMTP id E29E23806C; Mon, 25 Aug 2014 11:13:43 -0500 (CDT) X-Virus-Scanned: amavisd-new at icecube.wisc.edu Received: from i3mail.icecube.wisc.edu ([127.0.0.1]) by localhost (i3mail.icecube.wisc.edu [127.0.0.1]) (amavisd-new, port 10030) with ESMTP id 5xRypbfngFuJ; Mon, 25 Aug 2014 11:13:43 -0500 (CDT) Received: from comporellon.tachypleus.net (polaris.tachypleus.net [75.101.50.44]) by i3mail.icecube.wisc.edu (Postfix) with ESMTPSA id 3F2E03806B; Mon, 25 Aug 2014 11:13:43 -0500 (CDT) Message-ID: <53FB60B6.2020106@freebsd.org> Date: Mon, 25 Aug 2014 09:13:42 -0700 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: =?windows-1252?Q?Jean-S=E9bastien_P=E9dron?= , John Baldwin , Adrian Chadd Subject: Re: svn commit: r270516 - head/sys/dev/drm2/i915 References: <201408250503.s7P53Axo057720@svn.freebsd.org> <2177184.NMfUXrE71G@ralph.baldwin.cx> <53FB5FC8.4030105@FreeBSD.org> In-Reply-To: <53FB5FC8.4030105@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Aug 2014 16:13:44 -0000 On 08/25/14 09:09, Jean-Sébastien Pédron wrote: > On 25.08.2014 16:26, John Baldwin wrote: >> Also, is leaving around the #if 0'd Linux version something the drm2 >> code does >> in general or was that unique to this patch? If the latter, we >> should remove >> the duplicate #if 0 code (list_for_each, etc.) > > There's no actual consensus, I guess. In my DRM 3.8 branch, where I > try to reduce the diff with Linux, I try to provide wrappers and keep > the Linux code. > > Before that branch is merged, I'm in favor of keeping the Linux code > around (but maybe use #ifdef __FreeBSD__) to keep an history of what > was originally ported. > What is the status of that branch right now? It would be really, really, really nice to have actual Haswell graphics. -Nathan