From owner-freebsd-python@FreeBSD.ORG Fri Sep 5 21:05:08 2014 Return-Path: Delivered-To: python@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 79CDABA2 for ; Fri, 5 Sep 2014 21:05:08 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 611931D8A for ; Fri, 5 Sep 2014 21:05:08 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s85L58YV059961 for ; Fri, 5 Sep 2014 21:05:08 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 193314] [NEW PORT] www/py-seafdav: Addons to py-wsgidav Date: Fri, 05 Sep 2014 21:05:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: yan_jingfeng@yahoo.com X-Bugzilla-Status: Open X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: python@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Sep 2014 21:05:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193314 --- Comment #6 from Jingfeng Yan --- (In reply to Kubilay Kocak from comment #2) > Thanks for your submission Jingfen. > > Review items: > > * Leftover commented out items > * DISTNAME unnecessary Removed. > * LICENSE and LICENSE_FILE need values License provided. > * Use ${PYTHON_PKGNAMEPREFIX} for python RUN_DEPENDS checks unless > they are > for binaries. > * GH_PROJECT defaults to ${PORTNAME} already Fixed. > * The github repository has git tags, use them over direct to commit hashes > when > they're available By using tag name, the WRKDIR try to use tag, but by default it is use commit id. > * pkg-descr only contains a hash value, please create a proper pkg-descr Fixed. > > Additionally, > > Run your port through portlint -AC, and attach portlint output for this and > future submissions. provided. -- You are receiving this mail because: You are the assignee for the bug.