Date: Wed, 25 Feb 2015 10:51:15 -0600 From: Mark Felder <feld@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org>, marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Cc: jaap@NLnetLabs.nl Subject: Re: svn commit: r379920 - in head/dns/ldns: . files Message-ID: <1424883075.3274564.232309289.0D19C5CC@webmail.messagingengine.com> In-Reply-To: <51E869A1A81020445F3AC58F@ogg.in.absolight.net> References: <201502251444.t1PEig7Z044705@svn.freebsd.org> <54EDE96B.2080703@marino.st> <54EDEA5B.7090907@marino.st> <1424879169.3258486.232296941.283231A2@webmail.messagingengine.com> <51E869A1A81020445F3AC58F@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 25, 2015, at 10:06, Mathieu Arnold wrote: > +--On 25 f=E9vrier 2015 09:46:09 -0600 Mark Felder <feld@FreeBSD.org> > wrote: > | I'm not the maintainer; merely applied waiting maintainer-approved > | patches. It sounds like we should open a PR to address these issues, > | though. >=20 > Well, you're allowed to change a maintainer approved patch to fit our > rules/guidelines. >=20 Yeah, I'm not trying to weasel my way out of that. I take responsibility for not thoroughly reviewing the patch; it passed the smell test by building on 9.x and 10.x with both openssl and libressl :-) After a quick chat in IRC it appears that ldns is not respecting MAKE_ENV when it gets to that point, so the BSD_INSTALL_* are not available. :-( <@bapt> the port would need a lot of love :) Now I have to flog myself for leaving a spaces -> tab I failed to correct in the port Makefile
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1424883075.3274564.232309289.0D19C5CC>