From owner-cvs-all@FreeBSD.ORG Thu Jun 17 22:03:40 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F2D8F16A4E7 for ; Thu, 17 Jun 2004 22:03:37 +0000 (GMT) Received: from wbm2.pair.net (wbm2.pair.net [209.68.3.43]) by mx1.FreeBSD.org (Postfix) with SMTP id 79F1143D46 for ; Thu, 17 Jun 2004 22:03:37 +0000 (GMT) (envelope-from silby@silby.com) Received: (qmail 87962 invoked by uid 65534); 17 Jun 2004 22:03:13 -0000 Received: from 208.178.23.220 ([208.178.23.220]) (SquirrelMail authenticated user silby@silby.com); by webmail2.pair.com with HTTP; Thu, 17 Jun 2004 18:03:13 -0400 (EDT) Message-ID: <7071.208.178.23.220.1087509793.squirrel@208.178.23.220> In-Reply-To: <20040617214827.GB6029@electra.cse.Buffalo.EDU> References: <200406170008.i5H08NDt085108@repoman.freebsd.org> <20040617173854.GJ61448@elvis.mu.org> <20040617182031.GA8170@samodelkin.net> <20040617184518.GB831@electra.cse.Buffalo.EDU> <20040617204813.GA10670@samodelkin.net> <20040617214827.GB6029@electra.cse.Buffalo.EDU> Date: Thu, 17 Jun 2004 18:03:13 -0400 (EDT) From: "Mike Silbersack" To: "Ken Smith" User-Agent: SquirrelMail/1.4.3a X-Mailer: SquirrelMail/1.4.3a MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal cc: src-committers@freebsd.org cc: Max Khon cc: Alfred Perlstein cc: cvs-all@freebsd.org cc: cvs-src@freebsd.org cc: Ken Smith cc: Max Khon Subject: Re: cvs commit: src/sys/sys mbuf.h src/sys/kern uipc_mbuf.c uipc_syscalls.c src/usr.bin/netstat mbuf.c src/lib/libc/sys sendfile.2 X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2004 22:03:41 -0000 > On Fri, Jun 18, 2004 at 03:48:13AM +0700, Max Khon wrote: > > This particular change is a case of nit-picking. It's small, hard to > imagine how it could effect someone, etc. But even Bosko said more > caution 'next time' would be good, I'm just emphasizing why. To some > extent the output of programs has been an API ever since pipes were > invented. And unless I'm severely mistaken one of the things we have > tried to avoid is changing API's once a branch goes -STABLE. > > -- > Ken Smith Yes, you hit it right on the head, this IS a case of nitpicking. sfbufs are used almost exclusively in conjunction with mbufs, and users who are interested in mbuf usage will certainly be interested in sfbuf usage. This is why I displayed the information along with mbuf statistics, and why I see no reason to add yet another switch to netstat (or would it be sfstat?) I understand the script breakage argument, but I don't think it's particularly potent. Imagine this: We have ls, but it doesn't list file sizes, and there was no previous tool to list file sizes. Someone comes along and adds file size display to ls. However, due to objections about scripts breaking, this is backed up, and a seperate option , "ls -f" is added, which lists file sizes. This is the situation we're in here - there was NO previous way to see sfbuf statistics; we're adding new _and_ relevant data to "netstat -m". The implementation is an entirely different story, and I'm not disputing that it could be done better. Mike "Silby" Silbersack