Date: Mon, 1 Oct 2007 07:30:07 GMT From: Bruce Evans <brde@optusnet.com.au> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/116770: Unfortunate fifo/O_NONBLOCK/kevent interaction Message-ID: <200710010730.l917U7b3052645@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/116770; it has been noted by GNATS. From: Bruce Evans <brde@optusnet.com.au> To: Bo Lindbergh <blgl@stacken.kth.se> Cc: FreeBSD-gnats-submit@freebsd.org, freebsd-bugs@freebsd.org Subject: Re: kern/116770: Unfortunate fifo/O_NONBLOCK/kevent interaction Date: Mon, 1 Oct 2007 17:26:02 +1000 (EST) On Sun, 30 Sep 2007, Bo Lindbergh wrote: >> Description: > When a fifo with no writers is opened nonblockingly for reading and > the resulting file descriptor is added to a kqueue, kevent will > immediately report an EOF condition. This is less than useful. But it is an EOF condition: in this state, read() must return 0 to indicate EOF. select(), poll() and kqueue could have another mechanism for reporting this state, but don't in FreeBSD. Some other OS's have a specially broken select() and/or poll() for fifos but not for other file types so that the polling read condition doesn't actually report the read condition for fifos only. >> Fix: > Don't CANTRCVMORE the socketpair immediately after creating it. Add > code to fifo_read_f to avoid calling soreceive blockingly when there > are zero writers. That would break read(). > Or just add a fi_seen_at_least_one_writer flag to struct fifoinfo... Fixing this, or even implementing bug for bug compatibility with other OS's, is not easy. See PR's 34020, 53447, 76144, 76125, 76525, 94722 and the resulting commits for previous attempts to fix this. PR 94722 does something like this. It only tries to fix poll(). The behaviour of select() on a read descriptor cannot be changed, except to remove old buggy attempts to fix this problem, since select() on a read descriptor has no way to distinguish initial EOF from hangup. select() on an exceptional descriptor could consider hangup as an exception; there is no standard for this, but since exceptional descriptors are rarely used, changing the behaviour for them wouldn't break much. Kqueue has flags so it should be able to use the fix for poll() fairly easily. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710010730.l917U7b3052645>