From owner-freebsd-hackers Sun Nov 26 21: 4:49 2000 Delivered-To: freebsd-hackers@freebsd.org Received: from relay.butya.kz (butya-gw.butya.kz [212.154.129.94]) by hub.freebsd.org (Postfix) with ESMTP id 9FB3F37B479 for ; Sun, 26 Nov 2000 21:04:46 -0800 (PST) Received: by relay.butya.kz (Postfix, from userid 1000) id 05181289B9; Mon, 27 Nov 2000 11:04:37 +0600 (ALMT) Received: from localhost (localhost [127.0.0.1]) by relay.butya.kz (Postfix) with ESMTP id E83FD288DC; Mon, 27 Nov 2000 11:04:37 +0600 (ALMT) Date: Mon, 27 Nov 2000 11:04:37 +0600 (ALMT) From: Boris Popov To: Thomas Moestl Cc: freebsd-hackers@freebsd.org Subject: Re: [PATCH] Fix for panics in lookup() after forced unmount In-Reply-To: <20001126190453.A1157@crow.dom2ip.de> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, 26 Nov 2000, Thomas Moestl wrote: > Actually, the panic will occur after a simple forced unmount of the current > working directory and subsequent try to access "..". This is because the > vnode of the cwd was cleared and it's v_mount member was set to NULL. This > member is however dereferenced in the handling for the ".." special case in > lookup(), causing a panic. > The fix is rather trivial, just check the member before using it and return > an appropriate error. In the following patch, I use EBADF. > Btw, after taking a look into the OpenBSD and NetBSD repos, I think they > might have the same problem. Is there any standard channel to pass bug > reports to them from FreeBSD, or should I just use the normal submit > procedure? Good work Thomas! I think patch can be committed as is. -- Boris Popov http://www.butya.kz/~bp/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message