From owner-svn-ports-all@freebsd.org Thu Aug 27 11:23:40 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 724939C35C5; Thu, 27 Aug 2015 11:23:40 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4B83D1EA4; Thu, 27 Aug 2015 11:23:39 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [192.168.0.23] (unknown [130.255.19.36]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 2E7AF43B98; Thu, 27 Aug 2015 06:23:31 -0500 (CDT) Subject: Re: svn commit: r395409 - head/astro/geographiclib Reply-To: marino@freebsd.org, marino@freebsd.org References: <201508270944.t7R9ia0R067164@repo.freebsd.org> <20150827100953.GA78107@FreeBSD.org> <20150827105912.GF41937@hades.panopticon> <55DEEFC2.40309@marino.st> To: Dmitry Marakasov , Alexey Dokuchaev Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: John Marino Message-ID: <55DEF32C.5040202@marino.st> Date: Thu, 27 Aug 2015 13:23:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <55DEEFC2.40309@marino.st> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Aug 2015 11:23:40 -0000 On 8/27/2015 1:08 PM, John Marino wrote: > On 8/27/2015 12:59 PM, Dmitry Marakasov wrote: >> * Alexey Dokuchaev (danfe@FreeBSD.org) wrote: >> >>>> New Revision: 395409 >>>> URL: https://svnweb.freebsd.org/changeset/ports/395409 >>>> >>>> [...] >>>> GRAVITY_NAMES:= egm84 egm96 egm2008 wgs84 grs80 >>>> -MAGNETIC_NAMES:= wmm2010 wmm2015 igrf11 igrf12 emm2010 >>>> +MAGNETIC_NAMES:= wmm2010 wmm2015 igrf11 igrf12 emm2010 emm2015 >>> >>> Why := (assignment with immediate expansion) is used here, esp. for constant >>> values? >> >> Ask maintainer. >> > > I thought it had been clearly established (by mat@ IIRC) that this kind > of response is not acceptable as a reason for ports mistakes. The > committer is supposed to review the port he or she is committing and > catch errors. The maintainers simply don't have the same level of > experience as committers do. > > Probably answer: > Maintainer didn't know any better and the mistake has been missed every > time the port is maintained. > > I'm fine with "I missed it" but not so much with blaming the maintainer > or assuming the maintainer did it intentionally for a good technical reason. > FYI, I committed the first version and *I* missed it then. In my defense, I modified many, many things in that port. It needed a lot of help but I didn't see that one. John