Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 17 Jun 2015 09:39:11 -0600
From:      Adam Weinberger <adamw@adamw.org>
To:        Brad Davis <brd@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r389861 - in head/devel: cmake cmake-gui cmake-modules
Message-ID:  <AD97DB22-EE1C-4779-A29F-EAEDA09E1E73@adamw.org>
In-Reply-To: <201506162025.t5GKP6lx080770@svn.freebsd.org>
References:  <201506162025.t5GKP6lx080770@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> On 16 Jun, 2015, at 14:25, Brad Davis <brd@FreeBSD.org> wrote:
>=20
> Author: brd
> Date: Tue Jun 16 20:25:05 2015
> New Revision: 389861
> URL: https://svnweb.freebsd.org/changeset/ports/389861
>=20
> Log:
>  Update devel/cmake, devel/cmake-gui and devel/cmake-modules to 3.2.3.
>=20
> Modified: head/devel/cmake/Makefile
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>=20
> LIB_DEPENDS=3D	libcurl.so:${PORTSDIR}/ftp/curl \
> -		libexpat.so:${PORTSDIR}/textproc/expat2
> +		libexpat.so:${PORTSDIR}/textproc/expat2 \
> +		libjsoncpp.so:${PORTSDIR}/devel/jsoncpp

Does this port really need to depend on libjsoncpp? The version bundled =
with cmake works just fine (--no-system-jsoncpp).

The only benefit to making everybody install jsoncpp (and scons) would =
be if the jsoncpp port is updated more often than the cmake port. But =
the jsoncpp port hasn't had an update since the day it was added 16 =
months ago.

Can you please consider dropping the libjsoncpp dependency and just =
adding --no-system-jsoncpp to CONFIGURE_ARGS?

# Adam


--=20
Adam Weinberger
adamw@adamw.org
http://www.adamw.org




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AD97DB22-EE1C-4779-A29F-EAEDA09E1E73>