Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 Feb 2002 12:56:20 -0800 (PST)
From:      Matthew Dillon <dillon@apollo.backplane.com>
To:        Alfred Perlstein <bright@mu.org>, John Baldwin <jhb@FreeBSD.org>
Cc:        Seigo Tanimura <tanimura@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/coda coda_venus.c src/sys/compat/linprocfs
Message-ID:  <200202232056.g1NKuKf41350@apollo.backplane.com>
References:  <200202232030.g1NKU4m87533@freefall.freebsd.org> <20020223204610.GG80761@elvis.mu.org>

next in thread | previous in thread | raw e-mail | index | archive | help

:Matt, any chance you can co-ordinate with jhb (or not) to add
:functionality to witness such that it can detect when a mutex
:is aquired while holding a pool mutex?
:
:-Alfred

    This would be very easy to do.  Since witness already uses curthread
    we simply have a field in curthread indicating that we are holding a
    pool mutex.  If witness_lock() sees this set then it complains.  The
    pool mutexes could be init'd with another MTX flag indicating that
    they are leaf mutexes (i.e. MTX_LEAF).

    It is so easy it might be useful to do this test for INVARIANTS in
    general without requiring WITNESS to be turned on.

    What do you think John?

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200202232056.g1NKuKf41350>