From owner-cvs-all Sat Feb 23 12:56:25 2002 Delivered-To: cvs-all@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by hub.freebsd.org (Postfix) with ESMTP id AF28437B416; Sat, 23 Feb 2002 12:56:20 -0800 (PST) Received: (from dillon@localhost) by apollo.backplane.com (8.11.6/8.9.1) id g1NKuKf41350; Sat, 23 Feb 2002 12:56:20 -0800 (PST) (envelope-from dillon) Date: Sat, 23 Feb 2002 12:56:20 -0800 (PST) From: Matthew Dillon Message-Id: <200202232056.g1NKuKf41350@apollo.backplane.com> To: Alfred Perlstein , John Baldwin Cc: Seigo Tanimura , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/coda coda_venus.c src/sys/compat/linprocfs References: <200202232030.g1NKU4m87533@freefall.freebsd.org> <20020223204610.GG80761@elvis.mu.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :Matt, any chance you can co-ordinate with jhb (or not) to add :functionality to witness such that it can detect when a mutex :is aquired while holding a pool mutex? : :-Alfred This would be very easy to do. Since witness already uses curthread we simply have a field in curthread indicating that we are holding a pool mutex. If witness_lock() sees this set then it complains. The pool mutexes could be init'd with another MTX flag indicating that they are leaf mutexes (i.e. MTX_LEAF). It is so easy it might be useful to do this test for INVARIANTS in general without requiring WITNESS to be turned on. What do you think John? -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message