Date: Mon, 04 Mar 2013 09:41:25 -0600
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Eitan Adler <lists@eitanadler.com>
Cc: FreeBSD Ports <ports@freebsd.org>
Subject: Re: Using RUN_DEPENDS := ${BUILD_DEPENDS} is now a bug
Message-ID: <5134C0A5.7080601@FreeBSD.org>
In-Reply-To: <CAF6rxgmH9QJ2qYPT17W=nVUU2pYTfGmBBBwMDiQPA8SAj1tJuw@mail.gmail.com>
References: <CAF6rxgmH9QJ2qYPT17W=nVUU2pYTfGmBBBwMDiQPA8SAj1tJuw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2MRXFDENJASONKRABWNVS
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
On 3/3/2013 7:37 PM, Eitan Adler wrote:
> Some time ago ("2012-01-21 17:40:15 UTC") I committed a change which
> converted all uses of
>=20
> BUILD_DEPENDS=3D ${RUN_DEPENDS}
> to
> BUILD_DEPENDS:=3D ${RUN_DEPENDS}
>=20
> Writing:
>=20
> =3D=3D=3D=3D
> At the moment 1385 ports use BUILD_DEPENDS=3D ${RUN_DEPENDS} and 450
> ports use BUILD_DEPENDS:=3D ${RUN_DEPENDS}. This patch fixes ports th=
at are
> currently broken. This is a temporary measure until we organically st=
op using
> :=3D or someone(s) spend a lot of time changing all the ports over.
>=20
> Explicit duplication > :=3D > =3D and this just moves ports one step =
to the left
> =3D=3D=3D=3D
>=20
> With the introduction of devel/ccache support this is now a more critic=
al issue:
Note that this behavior of accidental run depends exists before
WITH_CCACHE_BUILD was introduced. Many features have this problem.
One specific simple example is USE_CMAKE.
You can see around 100 cases of this in Mk/:
# grep "BUILD_DEPENDS+=3D" Mk/*
>=20
> ports that use BUILD_DEPENDS:=3D ${RUN_DEPENDS} are buggy.
>=20
> Set WITH_CCACHE_BUILD=3Dyes in /etc/make.conf and observe
>=20
> [10046 eitan@gravity (100)% ...n/fbsd/ports/editors/led ]%make run-depe=
nds-list
> /usr/ports/lang/perl5.14
> [10047 eitan@gravity (100)% ...n/fbsd/ports/editors/led ]%vim Makefile
> # add "RUN_DEPENDS :=3D ${BUILD_DEPENDS}
> [10048 eitan@gravity (100)% ...n/fbsd/ports/editors/led ]%make run-depe=
nds-list
> /usr/ports/devel/ccache
> /usr/ports/lang/perl5.14
>=20
> Ports should *not* assume that BUILD_DEPENDS is clear when initiated
> and ports should explicitly duplicate RUN_DEPENDS.
>=20
> This also reduces the chance of making an error should BUILD_DEPENDS
> change to be inconsistent with BUILD_DEPENDS.
>=20
>=20
>=20
--=20
Regards,
Bryan Drewery
bdrewery@freenode/EFNet
------enig2MRXFDENJASONKRABWNVS
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRNMCzAAoJEG54KsA8mwz5WxMP/RWcYtqMIp8s5NUhqwg4zFYR
ryQ/1lQUxV6SuR1jlCBqEO3U9yRUk3LK9C2khR8CncR+3Gq/1TuF3ZcAxGtPbvtE
e3R1jMuA3lDUyNQvpzueF31AipEPk8V7JzAJXxgoZLRRU8PovtORmGb+lFFDhk5v
5REu95D58HppCFzM10FOC2vV9YVUgOy3gurBriBLHceTR16upOpEACbeHDVv3lTn
E5jcOg0HDH1j+s0Y1yoIBbP/39yWmjrkm9AK0itjwm2s0rRwIB2WbHb8XJNKSAIp
TBYmkwXOPN3jETb1vlDOYMK5HGSQ4l5k9Mgllq/YPJCZHAPo8VOuRVI8k0m5i44B
FiekSNnFWt2heVVgn6JjEBSqlRsyTYOqdWECWcDovQnZEaoJ5oapOo83wEv2UrLo
K7E/xePveZGeRB0ZUTWwgXnpd6HLvpEfWaaezp3jBY9QFJGRJ2StAc4MPj4xbawF
u+s4+p3U9et74yit7ALbhyzzTfnesrbFEQ+z/b46l0dvw5kUdh0z9Zx2bER7Qv1D
bY5jBH983jK/NydCkAWUMe3Ec0wHC1JX0Qc9sFe0sLnq1AIQvufIXgkD8wqDa8bd
IQ19EHXR0dKlrBDA2sqrp2U8J/Cxi6FEFGFVQmJA1fUquWaKOHTvg+NemReUFlu0
UYv1ATzDKVh08om7oQp4
=93cd
-----END PGP SIGNATURE-----
------enig2MRXFDENJASONKRABWNVS--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5134C0A5.7080601>