Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 14 Nov 2015 13:25:18 -0800
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        "Alexander V. Chernikov" <melifaro@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r290828 - head/sys/net
Message-ID:  <5647A6BE.3070408@FreeBSD.org>
In-Reply-To: <201511141816.tAEIGHVO000274@repo.freebsd.org>
References:  <201511141816.tAEIGHVO000274@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--dRCJuXhPHxqHBkfpDlvIoWTrjIdrxSOWN
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 11/14/2015 10:16 AM, Alexander V. Chernikov wrote:
> Author: melifaro
> Date: Sat Nov 14 18:16:17 2015
> New Revision: 290828
> URL: https://svnweb.freebsd.org/changeset/base/290828
>=20
> Log:
>   Pass provided af instead of AF_UNSPEC to setwa_f callback.
>=20
> Modified:
>   head/sys/net/route.c
>=20
> Modified: head/sys/net/route.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/net/route.c	Sat Nov 14 17:32:38 2015	(r290827)
> +++ head/sys/net/route.c	Sat Nov 14 18:16:17 2015	(r290828)
> @@ -845,7 +845,7 @@ rt_foreach_fib_walk(int af, rt_setwarg_t
>  			if (rnh =3D=3D NULL)
>  				continue;
>  			if (setwa_f !=3D NULL)
> -				setwa_f(rnh, fibnum, AF_UNSPEC, arg);
> +				setwa_f(rnh, fibnum, af, arg);
> =20
>  			RADIX_NODE_HEAD_LOCK(rnh);
>  			rnh->rnh_walktree(rnh, (walktree_f_t *)wa_f, arg);
>=20

Ah damn. I mis-read the 'if' a few lines up when fixing the coverity
warning. Sorry about that. At least none of the callbacks were using it y=
et.

--=20
Regards,
Bryan Drewery


--dRCJuXhPHxqHBkfpDlvIoWTrjIdrxSOWN
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJWR6a+AAoJEDXXcbtuRpfPqrAH/RfJiJ2YJ7jXBeMa36J4Snz8
oE8VGBjJkn0Fe8p7+i+MBWvpDIlAHesIb+Pt25A4Opj4EFZ4tZXp2NEEerVNX9/8
5poc+vU2N8txQsJWJJy19VPUy8mUjPJH+dEX+uYqgVkMhjoa9+BnGPrqfBCOnt4j
PDTV4bit93H+ZLHxrJSn3eVGFjbGA14CHgibG4g0dDCaV/peG1IQx7NL8W2APU98
psz4fXNig34CsYHvQa9Zjvp6jur5Ex47ir/rWja1Zhk3FIvDiJDR0cU29fjnUrJN
tGqFHktfop4QLrpUQ0+Ka477bhp3wVG808Ct064/Cg5R3RJ2rYSXtk7T6VxrAgk=
=a1zW
-----END PGP SIGNATURE-----

--dRCJuXhPHxqHBkfpDlvIoWTrjIdrxSOWN--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5647A6BE.3070408>