From owner-svn-src-all@FreeBSD.ORG Sat Aug 28 17:40:54 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 46C9A1065693; Sat, 28 Aug 2010 17:40:54 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id ADF668FC18; Sat, 28 Aug 2010 17:40:53 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 3EF8845EEF; Sat, 28 Aug 2010 19:40:52 +0200 (CEST) Received: from localhost (chello089077043238.chello.pl [89.77.43.238]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id E1BA845EE5; Sat, 28 Aug 2010 19:40:46 +0200 (CEST) Date: Sat, 28 Aug 2010 19:40:39 +0200 From: Pawel Jakub Dawidek To: Martin Matuska Message-ID: <20100828174039.GK2077@garage.freebsd.pl> References: <201008280924.o7S9OBgU025468@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zPXeIxDajdrcF2en" Content-Disposition: inline In-Reply-To: <201008280924.o7S9OBgU025468@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r211932 - in head/sys/cddl: compat/opensolaris/kern compat/opensolaris/sys contrib/opensolaris/uts/common contrib/opensolaris/uts/common/fs/zfs contrib/opensolaris/uts/common/fs/zfs/sys... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Aug 2010 17:40:54 -0000 --zPXeIxDajdrcF2en Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 28, 2010 at 09:24:11AM +0000, Martin Matuska wrote: > Author: mm > Date: Sat Aug 28 09:24:11 2010 > New Revision: 211932 > URL: http://svn.freebsd.org/changeset/base/211932 >=20 > Log: > Import changes from OpenSolaris that provide > - better ACL caching and speedup of ACL permission checks > - faster handling of stat() > - lowered mutex contention in the read/writer lock (rrwlock) > - several related bugfixes > =20 > Detailed information (OpenSolaris onnv changesets and Bug IDs): > =20 > 9749:105f407a2680 > 6802734 Support for Access Based Enumeration (not used on FreeBSD) > 6844861 inconsistent xattr readdir behavior with too-small buffer > =20 > 9866:ddc5f1d8eb4e > 6848431 zfs with rstchown=3D0 or file_chown_self privilege allows user = to "take" ownership > =20 > 9981:b4907297e740 > 6775100 stat() performance on files on zfs should be improved > 6827779 rrwlock is overly protective of its counters > =20 > 10143:d2d432dfe597 > 6857433 memory leaks found at: zfs_acl_alloc/zfs_acl_node_alloc > 6860318 truncate() on zfsroot succeeds when file has a component of its= path set without access permission > =20 > 10232:f37b85f7e03e > 6865875 zfs sometimes incorrectly giving search access to a dir > =20 > 10250:b179ceb34b62 > 6867395 zpool_upgrade_007_pos testcase panic'd with BAD TRAP: type=3De = (#pf Page fault) > =20 > 10269:2788675568fd > 6868276 zfs_rezget() can be hazardous when znode has a cached ACL > =20 > 10295:f7a18a1e9610 > 6870564 panic in zfs_getsecattr > =20 > Approved by: delphij (mentor) > Obtained from: OpenSolaris (multiple Bug IDs) > MFC after: 2 weeks [...] > --- head/sys/cddl/contrib/opensolaris/uts/common/Makefile.files Sat Aug 2= 8 08:59:55 2010 (r211931) > +++ head/sys/cddl/contrib/opensolaris/uts/common/Makefile.files Sat Aug 2= 8 09:24:11 2010 (r211932) > @@ -19,6 +19,9 @@ > # CDDL HEADER END > # > =20 > +ZUT_OBJS +=3D \ > + zut.o > + > # > # Copyright 2008 Sun Microsystems, Inc. All rights reserved. > # Use is subject to license terms. [...] > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/rrwlock.c Sat Aug= 28 08:59:55 2010 (r211931) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/rrwlock.c Sat Aug= 28 09:24:11 2010 (r211932) [...] > @@ -84,7 +82,7 @@ rrn_find(rrwlock_t *rrl) > rrw_node_t *rn; > =20 > if (refcount_count(&rrl->rr_linked_rcount) =3D=3D 0) > - return (NULL); > + return (B_FALSE); > =20 > for (rn =3D tsd_get(rrw_tsd_key); rn !=3D NULL; rn =3D rn->rn_next) { > if (rn->rn_rrl =3D=3D rrl) Those two chunks are incorrect, please consult my p4 branch. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --zPXeIxDajdrcF2en Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkx5ShYACgkQForvXbEpPzTWxgCgwLN01ElBY1uPLzm3Wy4AEpHK NQYAniB6L42r3bvjsGOWeYmkH7gZ8UX2 =DzFP -----END PGP SIGNATURE----- --zPXeIxDajdrcF2en--