From owner-cvs-all Mon Sep 11 4:39:52 2000 Delivered-To: cvs-all@freebsd.org Received: from relay.butya.kz (butya-gw.butya.kz [212.154.129.94]) by hub.freebsd.org (Postfix) with ESMTP id 49CEF37B424; Mon, 11 Sep 2000 04:39:47 -0700 (PDT) Received: by relay.butya.kz (Postfix, from userid 1000) id 9B2012876C; Mon, 11 Sep 2000 18:39:42 +0700 (ALMST) Received: from localhost (localhost [127.0.0.1]) by relay.butya.kz (Postfix) with ESMTP id 8ED0528766; Mon, 11 Sep 2000 18:39:42 +0700 (ALMST) Date: Mon, 11 Sep 2000 18:39:42 +0700 (ALMST) From: Boris Popov To: Bruce Evans Cc: Doug Rabson , John Baldwin , Doug Rabson , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys ktr.h In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, 11 Sep 2000, Bruce Evans wrote: > > I'll replace it with KASSERT-like definition: > > > > #define NULLFSDEBUG(args) printf args > > > > with appropriate changes to the rest of the code. > > I had almost accepted it. Is the only problem with the KASSERT-like > definition that double parentheses must be used when it is invoked? > This has the same problem as ITR* -- it messes up all invocations > of the macros. I think double parentheses more readable in compare with three lines of #ifdef/blah/#endif. In this case they are at the beginning and the end of invocation, so code doesn't turn to a mess. -- Boris Popov http://www.butya.kz/~bp/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message