Date: Sat, 1 Mar 2014 14:50:50 +0100 (CET) From: Christoph Moench-Tegeder <cmt@burggraben.net> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/187178: devel/readline : fix PKGNAME Message-ID: <20140301135050.3B03F301A8@elch.exwg.net> Resent-Message-ID: <201403011400.s21E00TS018513@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 187178
>Category: ports
>Synopsis: devel/readline : fix PKGNAME
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 01 14:00:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Christoph Moench-Tegeder
>Release: FreeBSD 10.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD elch.exwg.net 10.0-RELEASE FreeBSD 10.0-RELEASE #2 r260689: Wed Jan 15 18:32:44 CET 2014 cmt@elch.exwg.net:/usr/obj/usr/src/sys/ELCH amd64
devel/readline readline-6.3.
>Description:
When there are no PATCHES to readline, the PATCHLEVEL variable is
empty ("") which results in a PKGNAME of "readline-6.3." (note
trailing dot).
>How-To-Repeat:
cmt@disconnector:readline$ make -V PKGNAME
readline-6.3.
>Fix:
Append PATCHLEVEL only when there are patches (that's what the
enclosed patch does). Alternatively, force PATCHLEVEL to 0 in
case there are no patches.
Note for patch: PORTREVISION is not bumped, but I'm not sure how
the current port version compares on future updates.
Index: Makefile
===================================================================
--- Makefile (revision 346619)
+++ Makefile (working copy)
@@ -2,7 +2,7 @@
# $FreeBSD$
PORTNAME= readline
-PORTVERSION= 6.3.${PATCHLEVEL}
+PORTVERSION= 6.3${"${PATCHLEVEL}"!=""?".${PATCHLEVEL}":}
CATEGORIES= devel
MASTER_SITES= GNU \
ftp://ftp.cwru.edu/pub/bash/
Regards,
Christoph
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140301135050.3B03F301A8>