From owner-svn-src-all@FreeBSD.ORG Tue Jan 20 19:09:41 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EBB9C106564A; Tue, 20 Jan 2009 19:09:41 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from zim.MIT.EDU (ZIM.MIT.EDU [18.95.3.101]) by mx1.freebsd.org (Postfix) with ESMTP id A8CBE8FC17; Tue, 20 Jan 2009 19:09:41 +0000 (UTC) (envelope-from das@FreeBSD.ORG) Received: from zim.MIT.EDU (localhost [127.0.0.1]) by zim.MIT.EDU (8.14.3/8.14.2) with ESMTP id n0KJB4RU032928; Tue, 20 Jan 2009 14:11:04 -0500 (EST) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by zim.MIT.EDU (8.14.3/8.14.2/Submit) id n0KJB40f032927; Tue, 20 Jan 2009 14:11:04 -0500 (EST) (envelope-from das@FreeBSD.ORG) Date: Tue, 20 Jan 2009 14:11:04 -0500 From: David Schultz To: Roman Divacky Message-ID: <20090120191104.GA32825@zim.MIT.EDU> Mail-Followup-To: Roman Divacky , src-committers@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, svn-src-head@FreeBSD.ORG References: <200901201715.n0KHFCfw051198@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200901201715.n0KHFCfw051198@svn.freebsd.org> Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG Subject: Re: svn commit: r187475 - head/usr.bin/make X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2009 19:09:42 -0000 On Tue, Jan 20, 2009, Roman Divacky wrote: > Remove inlining of functions that are used mostly in different object files. > This gets rid of gnu89 style inlining. While I think fixing uses of 'inline' in the tree is a great goal, un-inlining accessor functions that compile down to a single machine instruction anyway may not be the best way to approach it. In cases like this, you can just use '__gnu89_inline', or even 'static inline' without causing any bloat. (In this particular case, I doubt that it really matters one way or the other.)