Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 01 Aug 2002 10:12:01 -0400 (EDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, grog@FreeBSD.org, obrien@FreeBSD.org, imp@bsdimp.com, phk@critter.freebsd.dk
Subject:   Re: cvs commit: src/sys/conf files src/sys/contrib/dev/acpica ac
Message-ID:  <XFMail.20020801101201.jhb@FreeBSD.org>
In-Reply-To: <20020801.205458.41625650.iwasaki@jp.FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 01-Aug-2002 Mitsuru IWASAKI wrote:
> Hi,
> 
>> In message <20020731.135639.119005865.imp@bsdimp.com>, "M. Warner Losh" writes:
>> 
>> >Actually, just include an EDITED version of changes.  The number of
>> >changes tends to be long, and a summary of them would be better.
>> >
>> >Of course, given that this is vendor code, and we're not quite working
>> >yet, I don't think that people will CARE if they don't know exactly
>> >what changed and why.  Look at some of the gcc import messages which
>> >basically said "Upgrade to version N".
>> 
>> Well, considering that ACPI can be quite a stumbling block for laptop
>> owners, I just wanted to minimal amount of text in the commit-msg
>> which would indicate to me if I needed to re-test on my laptop or
>> if this was likely to be a no-op for it.
> 
> Then, is importing CHANGES.txt good enough for your requirement?
> If so, I'm glad to ask Intel people and do so from the next vendor
> import.  I believe that it's the best solution for many people.
> 
> I'm not person from Intel, also not a ACPI CA developer actually, so
> information I can get is very limited other than CHANGES.txt.
> My private time is limited (especially now) as well as other
> committers, however I believe I did my best within my time and am
> going to make efforts as possible.
> If you require to me more things, then maybe I'm not suitable person
> for importing ACPI CA unfortunately :)  I can pass this work to other
> committer if necessary.
> But, I want to continue this actually and to follow traditional way of
> vendor import into FreeBSD CVS repo.  May I?

I think your commit was fine Iwasaki-san.  For most other 3rd party
software vendor imports just say that it is an upgrade to version
X.Y which is what you did.  One thing that might address people's
concerns if you have the time is to send an e-mail followup to the
commit message listing any major bugfixes or new features.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020801101201.jhb>