From owner-freebsd-net@FreeBSD.ORG  Mon Aug 31 23:04:04 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CCBBF106568F
	for <net@freebsd.org>; Mon, 31 Aug 2009 23:04:04 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outA.internet-mail-service.net (outa.internet-mail-service.net
	[216.240.47.224])
	by mx1.freebsd.org (Postfix) with ESMTP id B4A4A8FC15
	for <net@freebsd.org>; Mon, 31 Aug 2009 23:04:04 +0000 (UTC)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id B01C3B57E;
	Mon, 31 Aug 2009 16:04:04 -0700 (PDT)
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38])
	by idiom.com (Postfix) with ESMTP id E2E452D6013;
	Mon, 31 Aug 2009 16:04:03 -0700 (PDT)
Message-ID: <4A9C56E2.7070609@elischer.org>
Date: Mon, 31 Aug 2009 16:04:02 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
MIME-Version: 1.0
To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
References: <20090831215129.V93661@maildrop.int.zabbadoz.net>
In-Reply-To: <20090831215129.V93661@maildrop.int.zabbadoz.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: qingli@freebsd.org, FreeBSD networkers mailing list <net@freebsd.org>
Subject: Re: CFR/CFT: plug mbuf leak in new arp code
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Aug 2009 23:04:04 -0000

Bjoern A. Zeeb wrote:
> Hi,
> 
> I have a patch for FreeBSD 8.x / 9-CURRENT that plugs an mbuf leak
> in the new arp code that needs review and further testing.
> 
> Find a longer description of the problem at the beginning of the
> patch.  There is a lot of context in the patch; if you want a shorter
> one, apply and re-gen it.
> 
> If you want to see the current problem, log in to a remote 8/9 machine
> and repeatedly type ... over that connection (you need to be su):
>     arp -ad > /dev/null ; netstat -m | head -1
> Watch the first number. Warning: doing it too often will make that
> machine panic eventually.
> 
> Here's the patch:
> http://people.freebsd.org/~bz/20090831-01-plug-new-arp-mbuf-leak.diff
> 
> Thanks for your help in advance.
> 
> /bz
> 


looks pretty right...
all the paths I followed through did the right thing  WRT locks and mbufs.