From owner-freebsd-ports-bugs@freebsd.org Sat Apr 28 22:20:52 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D890DFBAFB2 for ; Sat, 28 Apr 2018 22:20:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 58AE272F91 for ; Sat, 28 Apr 2018 22:20:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 1D1BDFBAFB1; Sat, 28 Apr 2018 22:20:51 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0A892FBAFB0 for ; Sat, 28 Apr 2018 22:20:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9848B72F6A for ; Sat, 28 Apr 2018 22:20:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id C2BEB134C7 for ; Sat, 28 Apr 2018 22:20:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w3SMKnvM008298 for ; Sat, 28 Apr 2018 22:20:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w3SMKnm8008297 for ports-bugs@FreeBSD.org; Sat, 28 Apr 2018 22:20:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 210505] graphics/opencv: Update to 3.4.1 Date: Sat, 28 Apr 2018 22:20:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch, patch-ready X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: exp-run- merge-quarterly- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Apr 2018 22:20:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210505 --- Comment #76 from Jan Beich --- (In reply to Steve Wills from comment #75) > +CMAKE_ON=3D ENABLE_CXX11 > +CMAKE_OFF=3D BUILD_ZLIB BUILD_TIFF BUILD_JASPER BUILD_JPEG BUILD_PNG BUI= LD_OPENEXR BUILD_TBB BUILD_IPP_IW BUILD_ITT BUILD_PROTOBUF To fit on ~80 column terminal maybe wrap long lines CMAKE_ON=3D ENABLE_CXX11 CMAKE_OFF=3D BUILD_ZLIB BUILD_TIFF ... \ BUILD_ITT BUILD_PROTOBUF or use +=3D but group e.g., CMAKE_OFF+=3D BUILD_ZLIB CMAKE_OFF+=3D BUILD_TIFF CMAKE_OFF+=3D BUILD_JASPER ... > +# Optional 3rd party components > +CMAKE_ARGS+=3D -DWITH_1394:BOOL=3DOFF \ > + -DWITH_CAROTENE:BOOL=3DOFF \ Sorry, I meant to convert all (unconditional) CMAKE_ARGS to CMAKE_ON/OFF. > -V4L_CMAKE_ON=3D -DCMAKE_REQUIRED_INCLUDES:STRING=3D"${LOCALBASE}/includ= e" > +V4L_CMAKE_ON=3D CMAKE_REQUIRED_INCLUDES:STRING=3D"${LOCALBASE}/include" A typo: missing -D. Simply drop the change to the line. > Are there more to do or is that all that's needed? That was readability cosmetics. Review is not blocking (no maintainer) and = can be done in parallel to exp-run. Or did you try to build all consumers local= ly? --=20 You are receiving this mail because: You are the assignee for the bug.=