Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 19 Jun 2013 01:17:48 +0200
From:      John Marino <dragonflybsd@marino.st>
To:        Oliver Pinter <oliver.pntr@gmail.com>
Cc:        ports@freebsd.org, current@freebsd.org
Subject:   Re: gccmakedep fix - 20130619
Message-ID:  <51C0EA9C.5090502@marino.st>
In-Reply-To: <CAPjTQNF9wW2=xwzMiWMFrodW6P37y58mZ6M7qM-ZiNKzykDNFw@mail.gmail.com>
References:  <CAPjTQNF9wW2=xwzMiWMFrodW6P37y58mZ6M7qM-ZiNKzykDNFw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 6/19/2013 01:00, Oliver Pinter wrote:
> Hi all!
>
> Attached a fix to gccmakedep.


So....
1) There's already multiple PRs on this, including one I just submitted:
http://www.freebsd.org/cgi/query-pr.cgi?pr=179571

2) Your patch adds an ".endif" which is already there

3) Is not it better to submit via PR (GNATS) rather than a mailing list? 
  That's what PRs are for...

John




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51C0EA9C.5090502>