Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 29 Sep 2007 00:45:57 -0300
From:      "Alejandro Pulver" <alepulver@FreeBSD.org>
To:        "FreeBSD gnats submit" <FreeBSD-gnats-submit@FreeBSD.org>
Subject:   ports/116726: [PATCH] editors/cream: take VIMRUNTIME from editors/vim instead of hard coding
Message-ID:  <1191037557.41069@deimos.mars.bsd>
Resent-Message-ID: <200709290350.l8T3o1WF050327@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         116726
>Category:       ports
>Synopsis:       [PATCH] editors/cream: take VIMRUNTIME from editors/vim instead of hard coding
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Sep 29 03:50:01 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Alejandro Pulver
>Release:        FreeBSD 6.2-RELEASE i386
>Organization:
>Environment:


System: FreeBSD 6.2-RELEASE #0: Fri Jan 12 11:05:30 UTC 2007
    root@dessler.cse.buffalo.edu:/usr/obj/usr/src/sys/SMP



>Description:


Now the value of VIMRUNTIME is hard coded in the Makefile, with the patch it is taken from editors/vim, avoiding the need of updating this port's VIMRUNTIME variable each time editors/vim is updated.


>How-To-Repeat:





>Fix:


--- cream.diff begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/editors/cream/Makefile,v
retrieving revision 1.12
diff -u -r1.12 Makefile
--- Makefile	30 Jun 2007 18:43:40 -0000	1.12
+++ Makefile	29 Sep 2007 03:41:01 -0000
@@ -16,10 +16,12 @@
 RUN_DEPENDS=	${LOCALBASE}/bin/gvim:${PORTSDIR}/editors/vim
 
 NO_BUILD=	yes
-# needs updating for each major vim update.
-VIMRUNTIME=	${PREFIX}/share/vim/vim71
 PLIST_SUB=	VIMRUNTIME="${VIMRUNTIME:S/${PREFIX}\///}"
 
+.include <bsd.port.pre.mk>
+
+VIMRUNTIME!=	cd ${PORTSDIR}/editors/vim && ${MAKE} -V DATADIR
+
 do-install:
 	${INSTALL_SCRIPT} ${WRKSRC}/cream ${PREFIX}/bin
 	${MKDIR} ${VIMRUNTIME}/cream
@@ -40,4 +42,4 @@
 .endfor
 .endif
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--- cream.diff ends here ---



>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1191037557.41069>