From owner-cvs-src@FreeBSD.ORG Mon Aug 2 04:27:53 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B723D16A4CF; Mon, 2 Aug 2004 04:27:53 +0000 (GMT) Received: from robbins.dropbear.id.au (043.a.002.mel.iprimus.net.au [203.134.133.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id D2BEF43D4C; Mon, 2 Aug 2004 04:27:52 +0000 (GMT) (envelope-from tim@robbins.dropbear.id.au) Received: by robbins.dropbear.id.au (Postfix, from userid 1000) id 4EB7241CB; Mon, 2 Aug 2004 14:27:50 +1000 (EST) Date: Mon, 2 Aug 2004 14:27:50 +1000 From: Tim Robbins To: Alexey Dokuchaev Message-ID: <20040802042750.GA24962@cat.robbins.dropbear.id.au> References: <200408012045.i71KjtFX087582@repoman.freebsd.org> <20040802034509.GB81089@regency.nsu.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040802034509.GB81089@regency.nsu.ru> User-Agent: Mutt/1.4.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Garance A Drosehn Subject: Re: cvs commit: src/usr.bin/patch - Imported sources X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Aug 2004 04:27:53 -0000 On Mon, Aug 02, 2004 at 10:45:09AM +0700, Alexey Dokuchaev wrote: > On Sun, Aug 01, 2004 at 08:45:55PM +0000, Garance A Drosehn wrote: > > gad 2004-08-01 20:45:55 UTC > > > > FreeBSD src repository > > > > src/usr.bin/patch - Imported sources > > Update of /home/ncvs/src/usr.bin/patch > > In directory repoman.freebsd.org:/tmp/cvs-serv87568 > > > > Log Message: > > Import of a BSD-licensed version of `patch', which will eventually > > replace the version we currently have in src/gnu/usr.bin/patch/. > > Among other things, this version includes a --posix option for strict > > POSIX conformance. > > > > This version is the current source from OpenBSD as of today. It is > > their 3.5-release, plus a few updates to patch.c and pch.c that they > > made about three weeks ago. > > May I ask why you preferred OpenBSD's version over NetBSD's? It was > shown in the past that OpenBSD's way of doing thing is a bit rough on > the edges sometimes (humanize_number(3) vs. fmt_scaled(3) and > scan_scaled(3), ftw(3) and nftw(3), etc). Actually, OpenBSD's ftw()/nftw() implementation is better than the one we recently imported, in terms of both style and functionality; I wish we'd gone with it instead. What we have in -CURRENT at the moment is incredibly buggy for such a simple function. The droll, inane comments ("Because errno is our friend") and style violations only make things worse. Tim