Date: Sat, 21 Mar 2015 16:27:38 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Kubilay Kocak <koobs@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI <delphij@FreeBSD.org> Subject: Re: svn commit: r280308 - head/sys/fs/devfs Message-ID: <20150321142737.GJ2379@kib.kiev.ua> In-Reply-To: <550D5D49.6020503@FreeBSD.org> References: <201503210114.t2L1ECcB075556@svn.freebsd.org> <550D5D49.6020503@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 21, 2015 at 11:00:09PM +1100, Kubilay Kocak wrote: > On 21/03/2015 12:14 PM, Xin LI wrote: > > Author: delphij > > Date: Sat Mar 21 01:14:11 2015 > > New Revision: 280308 > > URL: https://svnweb.freebsd.org/changeset/base/280308 > > > > Log: > > Disable timestamping on devfs read/write operations by default. > > > > Currently we update timestamps unconditionally when doing read or > > write operations. This may slow things down on hardware where > > reading timestamps is expensive (e.g. HPET, because of the default > > vfs.timestamp_precision setting is nanosecond now) with limited > > benefit. > > > > A new sysctl variable, vfs.devfs.dotimes is added, which can be > > set to non-zero value when the old behavior is desirable. > > Perhaps *devfs_timestamp_update* is a better name. thoughts? > > If something shorter is desired: devfs_ts_update might be ok, though I > prefer the former. > > Let's not forget these are user visible system control knobs, not just > code variables, though I do understand the desire to shorten them, and > that we do have descriptions for them ... mostly :) should it be vfs.devfs.devfs_ts_devfs_ts_devfs_update_devfs so that user is _absolutely_ sure that it is devfs related, if 'devfs' used only one time in the MIB prevents him from realizing this ?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150321142737.GJ2379>