From owner-svn-ports-head@freebsd.org Thu Aug 25 13:23:23 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6DB28BC50EC; Thu, 25 Aug 2016 13:23:23 +0000 (UTC) (envelope-from kevlo@ns.kevlo.org) Received: from ns.kevlo.org (220-135-115-6.HINET-IP.hinet.net [220.135.115.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ns.kevlo.org", Issuer "ns.kevlo.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CF6341F3F; Thu, 25 Aug 2016 13:23:22 +0000 (UTC) (envelope-from kevlo@ns.kevlo.org) Received: from ns.kevlo.org (localhost [127.0.0.1]) by ns.kevlo.org (8.15.2/8.15.2) with ESMTPS id u7PDMYai050535 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 25 Aug 2016 21:22:34 +0800 (CST) (envelope-from kevlo@ns.kevlo.org) Received: (from kevlo@localhost) by ns.kevlo.org (8.15.2/8.15.2/Submit) id u7PDMXmY050534; Thu, 25 Aug 2016 21:22:33 +0800 (CST) (envelope-from kevlo) Date: Thu, 25 Aug 2016 21:22:33 +0800 From: Kevin Lo To: Chris Rees Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r420828 - head/net/py-nnpy Message-ID: <20160825132233.GA50525@ns.kevlo.org> References: <201608250020.u7P0K1GM086639@repo.freebsd.org> <5416C91F-F57A-4078-8E6A-A15CC195C1DC@physics.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5416C91F-F57A-4078-8E6A-A15CC195C1DC@physics.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Aug 2016 13:23:23 -0000 On Thu, Aug 25, 2016 at 09:26:06AM +0100, Chris Rees wrote: > Hi Kevin, Hi Chris, > You should really either expand BUILD_DEPENDS before assigning it, with := or assign BUILD_DEPENDS to RUN_DEPENDS instead. Doing that avoids pollution from later additions such as extra USES only used for build etc. > > PORTREVISION was unnecessary here too :) Fixed as r420849, thanks. > Cheers, > > Chris > > On 25 August 2016 01:20:01 BST, Kevin Lo wrote: > >Author: kevlo > >Date: Thu Aug 25 00:20:00 2016 > >New Revision: 420828 > >URL: https://svnweb.freebsd.org/changeset/ports/420828 > > > >Log: > > Add missing BUILD_DEPENDS. > > > > Spotted by: koobs > > > >Modified: > > head/net/py-nnpy/Makefile > > > >Modified: head/net/py-nnpy/Makefile > >============================================================================== > >--- head/net/py-nnpy/Makefile Wed Aug 24 23:49:06 2016 (r420827) > >+++ head/net/py-nnpy/Makefile Thu Aug 25 00:20:00 2016 (r420828) > >@@ -2,6 +2,7 @@ > > > > PORTNAME= nnpy > > PORTVERSION= 1.2 > >+PORTREVISION= 1 > > CATEGORIES= net python > > MASTER_SITES= CHEESESHOP > > PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} > >@@ -12,7 +13,8 @@ COMMENT= cffi-based Python bindings for > > LICENSE= MIT > > > > LIB_DEPENDS= libnanomsg.so:net/nanomsg > >-RUN_DEPENDS= ${PYTHONPREFIX_SITELIBDIR}/_cffi_backend.so:devel/py-cffi > >+BUILD_DEPENDS= ${PYTHONPREFIX_SITELIBDIR}/_cffi_backend.so:devel/py-cffi > >+RUN_DEPENDS= ${BUILD_DEPENDS} > > > > USES= python > > USE_PYTHON= autoplist distutils > > > > > >-- > >This message has been scanned for viruses and > >dangerous content by MailScanner, and is > >believed to be clean. > > -- > Sent from my Android device with K-9 Mail. Please excuse my brevity. > -- > This message has been scanned for viruses and > dangerous content by MailScanner, and is > believed to be clean. >