Date: Wed, 18 Feb 2015 23:34:00 +0100 From: Mathieu Arnold <mat@mat.cc> To: Victor Sudakov <vas@mpeks.tomsk.su>, freebsd-pkg@freebsd.org Subject: Re: "poudriere distclean" complains about /etc/make.conf Message-ID: <D0B4CE058DA7FBAEB1615050@atuin.in.mat.cc> In-Reply-To: <20150218163739.GA24716@admin.sibptus.tomsk.ru> References: <20150217043049.GA68755@admin.sibptus.tomsk.ru> <F8556CC1B58CDE1EE7646029@ogg.in.absolight.net> <20150218163739.GA24716@admin.sibptus.tomsk.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
+--On 18 f=C3=A9vrier 2015 22:37:39 +0600 Victor Sudakov =
<vas@mpeks.tomsk.su>
wrote:
| Mathieu Arnold wrote:
|> |=20
|> | I have the following construct in /etc/make.conf but not in
|> | /usr/local/etc/poudriere.d/make.conf:
|> |=20
|> | .if ${.CURDIR:M*/mail/spamassassin} && ${HOST} =3D=3D =
"relay.sibptus.ru"
|> | EXTRA_PATCHES+=3D/root/patches/Mail-SpamAssassin-3.3.1.sa-cgp.diff:-p1
|> | .endif
|> |=20
|> | When I run "poudriere distclean", it complains about this construct:=20
|> |=20
|> | WARNING (mail/spamassassin): "/etc/make.conf", line 15:
|> | Malformed conditional (${.CURDIR:M*/mail/spamassassin} && ${HOST} =
=3D=3D
|> | "relay.sibptus.ru") WARNING (mail/spamassassin):
|> | "/usr/share/mk/sys.mk", line 340: if-less endif WARNING
|> | (mail/spamassassin): make: fatal errors encountered -- cannot continue
|> |=20
|> | I have two questions.
|> |=20
|> | 1. Why does it complain? The conditional seems legit.
|>=20
|> It seems like it is, but it is not, it should be:
|>=20
|> .if !empty(.CURDIR:M*/mail/spamassassin) && ${HOST} =3D=3D =
"relay.sibptus.ru"
|> EXTRA_PATCHES+=3D/root/patches/Mail-SpamAssassin-3.3.1.sa-cgp.diff:-p1
|> .endif
|>=20
|> or
|>=20
|> .if ${.CURDIR:M*/mail/spamassassin} !=3D "" && ${HOST} =3D=3D
|> "relay.sibptus.ru"
|=20
| Sorry, Mathieu, your advice does not help:
|=20
| [root@svn ~] poudriere distclean -y
| [00:00:00] =3D=3D=3D=3D>> Gathering all expected distfiles for ports tree
| 'default' WARNING (mail/spamassassin): "/etc/make.conf", line 15:
| Malformed conditional (${.CURDIR:M*/mail/spamassassin} !=3D "" && ${HOST}
| =3D=3D "relay.sibptus.ru") WARNING (mail/spamassassin):
| "/usr/share/mk/sys.mk", line 340: if-less endif WARNING
| (mail/spamassassin): make: fatal errors encountered -- cannot continue=20
Ah, yes, HOST is not defined, it's why it fails, you need to add:
HOST?=3D
before that line, because you can't compare an undefined variable with
anything.
--=20
Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D0B4CE058DA7FBAEB1615050>