From owner-freebsd-ports-bugs@FreeBSD.ORG Sun May 12 05:40:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id A3B6BD16 for ; Sun, 12 May 2013 05:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 95C54B9E for ; Sun, 12 May 2013 05:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r4C5e13q003663 for ; Sun, 12 May 2013 05:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r4C5e1HK003662; Sun, 12 May 2013 05:40:01 GMT (envelope-from gnats) Date: Sun, 12 May 2013 05:40:01 GMT Message-Id: <201305120540.r4C5e1HK003662@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Cc: From: Shane Ambler Subject: Re: ports/178505: [maintainer update] for graphics/openimageio X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Shane Ambler List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 May 2013 05:40:01 -0000 The following reply was made to PR ports/178505; it has been noted by GNATS. From: Shane Ambler To: Raphael Kubo da Costa Cc: freebsd-ports-bugs@FreeBSD.org, bug-followup@FreeBSD.org Subject: Re: ports/178505: [maintainer update] for graphics/openimageio Date: Sun, 12 May 2013 15:02:11 +0930 On 12/05/2013 06:38, Raphael Kubo da Costa wrote: > Is the change to thread.h supposed to work on non-amd64 FreeBSD? Has > the patch been sent upstream? Short - yes and yes. Long - The patch originated with the discovery that i386 version crashed using tbb. The addition of arch=i586 to cflags enabled the use of gcc atomics. This was merged into the cmake files (src/cmake/platform.cmake) in 1.1.6 and taken out of the port makefile. 1.1.6 also included the removal of the freebsd condition in thread.h and by Larry Gritz's choice it was replaced with a test that left gcc atomics off if tbb was turned on. Disabling gcc atomics when tbb is on turned out to be a performance hit and 1.1.7 replaced the freebsd condition instead of removing the tbb test. I have submitted an issue for it (instead of a pull request) which seems to be the slow way of getting a change. While 1.1.8 appeared to be cli tools fixes and 1.1.9 was only docs, I don't want to drop behind so updating here with the patch.