From owner-freebsd-ports@FreeBSD.ORG Sun Dec 16 11:13:57 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5D2F5B9A; Sun, 16 Dec 2012 11:13:57 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id E7A298FC15; Sun, 16 Dec 2012 11:13:56 +0000 (UTC) Received: by mail-vc0-f182.google.com with SMTP id fy27so3895767vcb.13 for ; Sun, 16 Dec 2012 03:13:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding:content-type; bh=wxJx1KwJW0CwJFt9NZDnJp5OYC7tlMm41ENu/eijnNw=; b=RRFbhaYFa/m9kobeCxpu+00tRyKn9Dle3661M81Pc+e8aTZeKspq2fVytgS1GPtv6d CXdEVNT5hfNi7E8yHqOYLnVTtSe0BcK5PutaE9/OpfBJz16FTfPxj+3yXlfUevkyOp4i 4JbA7XXMxZAZAqBJBcJWTPEJxWlYIqO7+FFRqfZb5YCrTWC1Gxk3fXGOXCjOD1AN+Z0t bNsetpjwJ5jZA0lu/Gxcj9nlera6oQTqMRRH4s3Ecy0D8a9YWsuSXCvuCeIjYbWHNpAQ BpzsV2KhwcIKxpaLnGWk+iPQ3tjEi0da1mM/vmtnP/rfCntp3A/NG2w3Q4DpKoLyoBnN GEZg== Received: by 10.58.137.7 with SMTP id qe7mr18591484veb.23.1355656436153; Sun, 16 Dec 2012 03:13:56 -0800 (PST) Received: from mocha.verizon.net (c-71-61-40-68.hsd1.oh.comcast.net. [71.61.40.68]) by mx.google.com with ESMTPS id yu4sm8309988veb.7.2012.12.16.03.13.55 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 16 Dec 2012 03:13:55 -0800 (PST) Sender: "Jason E. Hale" From: "Jason E. Hale" To: Ruslan Makhmatkhanov Subject: Re: [@ ports committers] ports/173531 Date: Sun, 16 Dec 2012 06:13:53 -0500 Message-ID: <3096099.yLIANgpWSo@mocha.verizon.net> User-Agent: KMail/4.8.4 (FreeBSD/9.0-RELEASE-p3; KDE/4.8.4; i386; ; ) In-Reply-To: <50CDAB84.5050701@yandex.ru> References: <50CD99F2.4010205@gmx.eu> <50CDA9A7.7010401@yandex.ru> <50CDAB84.5050701@yandex.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Cc: marco.broeder@gmx.eu, freebsd-ports@freebsd.org, bug-followup@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Dec 2012 11:13:57 -0000 On Sunday, December 16, 2012 15:07:48 Ruslan Makhmatkhanov wrote: > Ruslan Makhmatkhanov wrote on 16.12.2012 14:59: > > Hi Marco, > >=20 > > Marco Br=F6der wrote on 16.12.2012 13:52: > >> Hi, > >>=20 > >> could a ports committer take ports/173531 pr, please? It is unassi= gned > >> for > >> over a month, now. > >>=20 > >> Thank you very much! > >=20 > > Please review patch attached. I changed some things in your patch: > > - using OPTIONSFILE instead of UNIQUENAME (it's common practice to = fix > >=20 > > things like that) > >=20 > > - limit to python 2.x (dulwich is not python 3.x-aware yet) > > - tab -> space change in pkg-descr:WWW (style bug) > > - remove DOCS_DESC (we have generic description in bsd.options.desc= .mk) > > - use PYTHON_CMD instead of ``/usr/bin/env python'' (to make sure i= t > >=20 > > will be runned with the same python branch, that it was built wi= th) > >=20 > > Please let me know if you agree with the changes, and I commit the > > update shortly. > >=20 > > PS. Surely, it builds fine with this patch. >=20 > Oops, I see that this pr was taken by jhale already :) Ruslan, If you want to take this that is fine with me...I haven't started worki= ng on=20 it yet and it seems you have looked into it already. > One more thing - PORTDOCS should be defined uncoditionally, but > installed conditionally: >=20 > +.if ${PORT_OPTIONS:MDOCS} > +PORTDOCS=3D=09AUTHORS COPYING HACKING NEWS README introduction.txt \= > +=09=09object-store.txt protocol.txt remote.txt repo.txt > .endif >=20 COPYING should be removed here too. LICENSE is already defined. > This condition is not necessary. --=20 Jason E. Hale - jhale@ FreeBSD Ports Committer KDE/FreeBSD Team