Date: Thu, 4 Nov 2010 20:57:53 -0700 From: "Moore, Robert" <robert.moore@intel.com> To: "Moore, Robert" <robert.moore@intel.com>, Hans Petter Selasky <hselasky@c2i.net>, Jung-uk Kim <jkim@freebsd.org>, "freebsd-acpi@freebsd.org" <freebsd-acpi@freebsd.org> Cc: "Therien, Guy" <guy.therien@intel.com> Subject: RE: MacBookPro 5,1 Message-ID: <4911F71203A09E4D9981D27F9D830858BC46A4B1@orsmsx503.amr.corp.intel.com> References: <201010121209.06397.hselasky@c2i.net> <4CD02E6D.1070106@freebsd.org> <201011021529.05977.jkim@FreeBSD.org> <201011040844.17109.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
The problem is stale pointers within the structure, yes? Cannot copy the structure. I will never do this kind of thing again. When ACPICA was designed 12 years ago, memory was expensive. Bob >-----Original Message----- >From: Moore, Robert >Sent: Thursday, November 04, 2010 7:24 PM >To: 'Hans Petter Selasky'; Jung-uk Kim; freebsd-acpi@freebsd.org >Subject: RE: MacBookPro 5,1 > > >You cannot assume that a full memcpy has been performed on the structure >when you invoke the equals operator. > >This is basic C > > > > > >>-----Original Message----- >>From: owner-freebsd-acpi@freebsd.org [mailto:owner-freebsd- >>acpi@freebsd.org] On Behalf Of Hans Petter Selasky >>Sent: Thursday, November 04, 2010 12:44 AM >>To: Jung-uk Kim; freebsd-acpi@freebsd.org >>Subject: Re: MacBookPro 5,1 >> >>On Tuesday 02 November 2010 20:29:01 Jung-uk Kim wrote: >>> > Hans, >>> > >>> > could you please test the following patch? >>> > >>> > diff --git a/sys/dev/acpica/acpi_pci_link.c >>> > b/sys/dev/acpica/acpi_pci_link.c index dcf101d..e842635 100644 >>> > --- a/sys/dev/acpica/acpi_pci_link.c >>> > +++ b/sys/dev/acpica/acpi_pci_link.c >>> > @@ -767,6 +767,8 @@ acpi_pci_link_srs_from_crs >>> > >>> > link->l_irq; >>> > else >>> > resptr->Data.ExtendedIrq.Interrupts[0] = =3D >>0; >>> > >>> > + memset(&resptr->Data.ExtendedIrq.ResourceSource= , >>0, >>> > + sizeof(ACPI_RESOURCE_SOURCE)); >>> > >>> > link++; >>> > i++; >>> > break; >> >>The "Bug" statements disappeared with this patch! Which patch is next to >>try? >> >>--HPS >>_______________________________________________ >>freebsd-acpi@freebsd.org mailing list >>http://lists.freebsd.org/mailman/listinfo/freebsd-acpi >>To unsubscribe, send any mail to "freebsd-acpi-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4911F71203A09E4D9981D27F9D830858BC46A4B1>