From owner-svn-src-all@freebsd.org Wed May 11 17:27:28 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 944D4B37A87; Wed, 11 May 2016 17:27:28 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 650541FD0; Wed, 11 May 2016 17:27:28 +0000 (UTC) (envelope-from cem@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u4BHRRpb046047; Wed, 11 May 2016 17:27:27 GMT (envelope-from cem@FreeBSD.org) Received: (from cem@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u4BHRRRe046046; Wed, 11 May 2016 17:27:27 GMT (envelope-from cem@FreeBSD.org) Message-Id: <201605111727.u4BHRRRe046046@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: cem set sender to cem@FreeBSD.org using -f From: "Conrad E. Meyer" Date: Wed, 11 May 2016 17:27:27 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r299470 - head/usr.sbin/mixer X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2016 17:27:28 -0000 Author: cem Date: Wed May 11 17:27:27 2016 New Revision: 299470 URL: https://svnweb.freebsd.org/changeset/base/299470 Log: mixer(8): Style: Tag no-return usage() as __dead2 Coverity really should have figured this out from the exit(3) call at the end of the routine, but just make it explicit. No functional change. Reported by: Coverity CID: 1304866 (false positive double-close of 'baz') Sponsored by: EMC / Isilon Storage Division Modified: head/usr.sbin/mixer/mixer.c Modified: head/usr.sbin/mixer/mixer.c ============================================================================== --- head/usr.sbin/mixer/mixer.c Wed May 11 17:20:20 2016 (r299469) +++ head/usr.sbin/mixer/mixer.c Wed May 11 17:27:27 2016 (r299470) @@ -26,11 +26,11 @@ __FBSDID("$FreeBSD$"); static const char *names[SOUND_MIXER_NRDEVICES] = SOUND_DEVICE_NAMES; -static void usage(int devmask, int recmask); +static void usage(int devmask, int recmask) __dead2; static int res_name(const char *name, int mask); static void print_recsrc(int recsrc, int recmask, int sflag); -static void +static void __dead2 usage(int devmask, int recmask) { int i, n;