Date: Wed, 31 Oct 2012 11:25:37 +0100 From: Olivier Houchard <cognet@ci0.org> To: Giovanni Trematerra <gianni@freebsd.org> Cc: freebsd-arm@freebsd.org Subject: Re: [PATCH] use vtophys instead of pmap_kextract Message-ID: <20121031102536.GA25336@ci0.org> In-Reply-To: <CACfq093f9w8BXOboHV0jy6OMKjCdVaD5BJPT%2BgZ9bn%2ByuQJHbg@mail.gmail.com> References: <CACfq093f9w8BXOboHV0jy6OMKjCdVaD5BJPT%2BgZ9bn%2ByuQJHbg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Giovanni, On Tue, Oct 30, 2012 at 11:12:20PM +0100, Giovanni Trematerra wrote: > Hi, > could you please review and commit the patch below? > > The patch changes the calls to pmap_kextract in vtophys macro. > This also fixes a compiler warning when SMP is enabled to Marvel > ARMADA XP boards. > I'm not sure there's a point in doing this, the uses of pmap_kextract() are legit, and using vtophys() instead would just hide potential type bugs. I'd rather just explicitely add a cast in the Marvel code, as your original patch for the TI code did. Regards, Olivier
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121031102536.GA25336>