Date: Mon, 25 Oct 2021 21:38:09 +0200 From: Tobias Kortkamp <tobik@freebsd.org> To: "Sergey A. Osokin" <osa@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 15d43d187799 - main - databases/redisjson: Chase USES=cargo's new git source support Message-ID: <YXcHoRM6d%2BO0fMHV@loki.kortkamp.xyz> In-Reply-To: <YXb5bu/8ymAqZbUU@FreeBSD.org> References: <202110250857.19P8v4v1099045@gitrepo.freebsd.org> <YXb5bu/8ymAqZbUU@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4WpGm4THisfBD6wG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 25, 2021 at 06:37:34PM +0000, Sergey A. Osokin wrote: > Hi Tobias, >=20 > thanks for the update of the port. >=20 > This new approach looks unclear to me, why it's better than GH_TUPLE? > So long line in the CARGO_CRATES list with the branch name, commit > and an escape symbol looks not so convenient to me. >=20 > Does that how the `make cargo-crates` generates CARGO_CRATES from now? - CARGO_CRATES is generated with make cargo-crates as before. Nothing really changes for maintainers. You are not supposed to write those lines manually - The URLs come straight from Cargo.lock as such the URL format is the one that Cargo uses for git sources - Before the first @ is a ,-separated list of all crate names that are inside of the repository - Mapping to G?_TUPLE would loose information (the crate names) which we need later - Also see 2bad8d171afe848ac88585270964342a55d504ce --4WpGm4THisfBD6wG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAmF3B5pfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2FdSgf/cozLDnsNs2VmngdUjhx/w5BK8BXtvaLPHahNPNxZNIhivhA8z4orjgsO 2eCDSHRHFM5vW9eznAex52TkJFsZl4IFynlAlA5AhjkSV5b6Bwa+1kUBe0/LZ9sn S3Ncqqm7lR9l1uhR26gBH9X1byZJwd4EPhnezxI0lAQnzl+PQPwjwIWjdk9A9KgG CUvNA1Vg3XvW7n5zc1By8Hf2Fe6oA0rYSlwMvjdTKjhU5jcT3owmUazjlPP7iaGm l76gFlXl1hiUSkiiwyfCfpTN8vKHrgpJF0cVc7CydAwcQS+4dO8HHzb2X9CdoYgl NF8BlvmmvOc+D8N8IeWnrcOcSluImg== =uNe9 -----END PGP SIGNATURE----- --4WpGm4THisfBD6wG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YXcHoRM6d%2BO0fMHV>