From owner-svn-ports-head@FreeBSD.ORG  Thu Sep  6 23:47:40 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
	by hub.freebsd.org (Postfix) with ESMTP id 14778106566B;
	Thu,  6 Sep 2012 23:47:40 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id BDA39153B36;
	Thu,  6 Sep 2012 23:46:12 +0000 (UTC)
Message-ID: <504935C4.9090104@FreeBSD.org>
Date: Thu, 06 Sep 2012 16:46:12 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Mozilla/5.0 (Windows NT 5.1;
	rv:14.0) Gecko/20120713 Thunderbird/14.0
MIME-Version: 1.0
To: Ryan Steinmetz <zi@FreeBSD.org>
References: <201209060303.q8633mHv048390@svn.freebsd.org>
In-Reply-To: <201209060303.q8633mHv048390@svn.freebsd.org>
X-Enigmail-Version: 1.4.3
OpenPGP: id=1A1ABC84
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
	Karsten Schmidt <gugge@guggemand.dk>, ports-committers@freebsd.org
Subject: Re: svn commit: r303734 - head/net-mgmt/pmacct/files
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the ports tree for head
	<svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>, 
	<mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
	<mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Sep 2012 23:47:40 -0000

Overall this rc.d script looks Ok. My one suggestion is that if -D is
the option to daemonize that it be moved to command_args instead of
relying on the user not to forget to include it if they override _flags.

Doug


On 9/5/2012 8:03 PM, Ryan Steinmetz wrote:
> Author: zi
> Date: Thu Sep  6 03:03:47 2012
> New Revision: 303734
> URL: http://svn.freebsd.org/changeset/ports/303734
> 
> Log:
>   - Fix issues in rc script + pkg-message
>   
>   Submitted by:	Karsten Schmidt <gugge@guggemand.dk>
> 
> Modified:
>   head/net-mgmt/pmacct/files/pkg-message.in
>   head/net-mgmt/pmacct/files/pmacctd.in
> 
> Modified: head/net-mgmt/pmacct/files/pkg-message.in
> ==============================================================================
> --- head/net-mgmt/pmacct/files/pkg-message.in	Thu Sep  6 02:30:30 2012	(r303733)
> +++ head/net-mgmt/pmacct/files/pkg-message.in	Thu Sep  6 03:03:47 2012	(r303734)
> @@ -3,7 +3,7 @@ Please note that this port requires conf
>  
>  Add these to /etc/rc.conf:
>  pmacctd_enable="YES"
> -pmacctd_flags="-DF %%PREFIX%%/etc/pmacctd.conf -i <interface>"
> +pmacctd_flags="-Df %%PREFIX%%/etc/pmacctd.conf -i <interface>"
>  
>  Configuration examples are located in %%EXAMPLESDIR%%.  You must copy
>  one of these to %%PREFIX%%/etc/pmacctd.conf and make any required edits
> 
> Modified: head/net-mgmt/pmacct/files/pmacctd.in
> ==============================================================================
> --- head/net-mgmt/pmacct/files/pmacctd.in	Thu Sep  6 02:30:30 2012	(r303733)
> +++ head/net-mgmt/pmacct/files/pmacctd.in	Thu Sep  6 03:03:47 2012	(r303734)
> @@ -25,7 +25,7 @@
>  name=pmacctd
>  rcvar=pmacctd_enable
>  
> -command=%%PREFIX%%/$name
> +command=%%PREFIX%%/sbin/$name
>  
>  # set defaults
>  
> 


-- 

    I am only one, but I am one.  I cannot do everything, but I can do
    something.  And I will not let what I cannot do interfere with what
    I can do.
			-- Edward Everett Hale, (1822 - 1909)