Date: Tue, 2 Jul 2019 10:44:15 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: Piotr Kubaj <pkubaj@anongoth.pl>, Greg Lewis <glewis@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r505640 - head/java/openjdk11 Message-ID: <20190702104415.GB59302@FreeBSD.org> In-Reply-To: <20190702083515.seykaqqjd77zyyr2@ivaldir.net> References: <201907012118.x61LIIQr011692@repo.freebsd.org> <20190702072450.GA17073@KGPE-D16> <20190702082607.GA45590@FreeBSD.org> <20190702083515.seykaqqjd77zyyr2@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 02, 2019 at 10:35:15AM +0200, Baptiste Daroussin wrote: > On Tue, Jul 02, 2019 at 08:26:08AM +0000, Alexey Dokuchaev wrote: > > On Tue, Jul 02, 2019 at 09:24:50AM +0200, Piotr Kubaj wrote: > > > Why not use USES=compiler:c11 instead of setting manually USE_GCC=yes? > > > > Technically they're semantically not the same; while pulling C11-capable > > compiler might fix the problem, you're still telling the reader that > > you're pulling C11-capable compiler, while USE_GCC means that you want > > GCC, devoid of particular reasons. > > > > In practice, compiler:c11 often used as compiler:modern. [...] > > Actually the majority of addition of compiler:c11 are wrong (from the one > I have been able to check) I tend to agree. :( > It would be really nice to stop blindy using compiler:c11 ;) Right; unfortunately, often people who commit these changes do not bother to check with the actual code to see if a different/better solution is available (or even in order). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190702104415.GB59302>