From owner-cvs-src@FreeBSD.ORG Mon Aug 9 03:13:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A965A16A4CE; Mon, 9 Aug 2004 03:13:57 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 87A3843D2D; Mon, 9 Aug 2004 03:13:57 +0000 (GMT) (envelope-from yongari@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i793DvZ4040383; Mon, 9 Aug 2004 03:13:57 GMT (envelope-from yongari@repoman.freebsd.org) Received: (from yongari@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i793DvoI040382; Mon, 9 Aug 2004 03:13:57 GMT (envelope-from yongari) Message-Id: <200408090313.i793DvoI040382@repoman.freebsd.org> From: Pyun YongHyeon Date: Mon, 9 Aug 2004 03:13:57 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sbin/ifconfig ifconfig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Aug 2004 03:13:57 -0000 yongari 2004-08-09 03:13:57 UTC FreeBSD src repository Modified files: sbin/ifconfig ifconfig.c Log: Fix long standing mediaopt setting bugs seen on sparc64. Though the bug exists in little-endian machine, it was not triggered due to the difference of memory ordering between little/big endian machines. Instead of relying on possibly modified value during function invokcations, use saved copy of ifr.ifr_addr.sa_family. Also add a comment at the top of ifconfig.c clarifying the issue so the bug won't re-appear. Approved by: jake Reviewed by: yar Revision Changes Path 1.106 +12 -6 src/sbin/ifconfig/ifconfig.c