From owner-freebsd-mobile Thu Sep 12 14:12:27 2002 Delivered-To: freebsd-mobile@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CD80037B400 for ; Thu, 12 Sep 2002 14:12:25 -0700 (PDT) Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id 67B0343E4A for ; Thu, 12 Sep 2002 14:12:25 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 30802 invoked from network); 12 Sep 2002 21:12:25 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail12.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 12 Sep 2002 21:12:25 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.5/8.12.5) with ESMTP id g8CLCNBv040183; Thu, 12 Sep 2002 17:12:23 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020912205654.GB1602@laptop.6bone.nl> Date: Thu, 12 Sep 2002 17:12:24 -0400 (EDT) From: John Baldwin To: Mark Santcroos Subject: Re: pccard re-attach after ACPI S1 resume Cc: mobile@FreeBSD.ORG Sender: owner-freebsd-mobile@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On 12-Sep-2002 Mark Santcroos wrote: > On Thu, Sep 12, 2002 at 04:53:15PM -0400, John Baldwin wrote: >> > Then we do an attach on a slot where we know there isn't anything anyway. >> > That basicly doesn't make sense, and it also spits out all kind of ulgy >> > messages that we don't want/need. >> >> We do a detach when we don't know if something is there in pccard_suspend(). >> :) Maybe pccard_attach_card() could take an argument to tell it to not >> whine if there is no card there. > > That's true :) Whatever you think is best. As long as I don't have to > reboot. I'm coming pretty close to a fully usable laptop now! > > Anyway, is this the right place you think or should we kick it up to pccbb? Well, Warner is Mr. Newcard, so it is really his opinion that matters. :) Logically since we always do a detach() in suspend() I think we should always do an attach() on resume() but just silently fail if there is no card. Imagine if you suspended with a card in and then ejected it. You would still get a bunch of warning message from attach() when instead it should just handle the situation quietly. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message