From owner-freebsd-current@FreeBSD.ORG Tue Jul 29 01:36:24 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B5A411065674 for ; Tue, 29 Jul 2008 01:36:24 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from mx.egr.msu.edu (surfnturf.egr.msu.edu [35.9.37.164]) by mx1.freebsd.org (Postfix) with ESMTP id 870F68FC1B for ; Tue, 29 Jul 2008 01:36:24 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from localhost (localhost [127.0.0.1]) by mx.egr.msu.edu (Postfix) with ESMTP id E814171F2C5; Mon, 28 Jul 2008 21:36:23 -0400 (EDT) X-Virus-Scanned: amavisd-new at egr.msu.edu Received: from mx.egr.msu.edu ([127.0.0.1]) by localhost (surfnturf.egr.msu.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4B3lYf+JTVnh; Mon, 28 Jul 2008 21:36:23 -0400 (EDT) Received: from localhost (daemon.egr.msu.edu [35.9.44.65]) by mx.egr.msu.edu (Postfix) with ESMTP id C5C0371F1B5; Mon, 28 Jul 2008 21:36:23 -0400 (EDT) Received: by localhost (Postfix, from userid 21281) id AF00B72D; Mon, 28 Jul 2008 21:36:23 -0400 (EDT) Date: Mon, 28 Jul 2008 21:36:23 -0400 From: Adam McDougall To: David Grochowski Message-ID: <20080729013623.GF79560@egr.msu.edu> References: <20080727125413.GG1345@garage.freebsd.pl> <20080728032427.GN79560@egr.msu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org Subject: Re: ZFS patches. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jul 2008 01:36:24 -0000 Thanks, that worked! My laptop is upgraded and running from it with root mounted from zfs. It seems like there is less compulsory disk activity like there used to be every ~3 seconds when idle, that is welcome. I've only ran my laptop with it about 30 minutes so far, two different boots. The first time I shut down I think I saw around 10-15 unexpected messages something like zfs_umount: force unmount not supported, removing FORCE flag. No problems though, it was probably one for each of my 13 zfs mounts. You got my vote for this to be committed to -current. I'll be loading this onto a few more systems as I get a chance, all of which I'll have to upgrade to -current and don't mind doing for a worthwhile reason, including a download mirror server and a backups server. I'll probably hold off on upgrading the fs version to 11 until I don't need to patch the source, incase I forget to on an upgrade. I do have some others running ZFS without problem that will have to wait for a 7.x patch but since they are running fine, I can wait as long as needed. On Mon, Jul 28, 2008 at 12:55:49AM -0400, David Grochowski wrote: Hey, On Sun, Jul 27, 2008 at 11:24 PM, Adam McDougall wrote: > > /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c > /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:35: > error: expected ')' before '*' token > /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c: > In function 'zfs_oldacl_byteswap': > /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:127: > error: 'ace_t' undeclared (first use in this function) I had the same issue. Try deleting "/usr/src/sys/cddl/compat/opensolaris/sys/acl.h" and "/usr/src/sys/cddl/compat/opensolaris/sys/callb.h" (make sure that these files have a length of zero first!). When patching, these files are supposed to be deleted, but were instead left as empty files. Since these files are included before the actual ones in "/usr/src/sys/cddl/contrib/opensolaris/uts/common/sys", this will cause a problem. Also, I would like to note that the patch has been working for me without any problems. Sincerely, Dave Grochowski _______________________________________________ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"