Date: Sun, 20 Apr 2003 20:53:11 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: David Schultz <das@freebsd.org> Cc: freebsd-bugs@freebsd.org Subject: Re: bin/51151: du hardlinkmatching is slow - fix included Message-ID: <20030420204940.N19972@gamplex.bde.org> In-Reply-To: <200304201000.h3KA0WYk023513@freefall.freebsd.org> References: <200304201000.h3KA0WYk023513@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 20 Apr 2003, David Schultz wrote: > On Sun, Apr 20, 2003, Peter van Dijk wrote: > > On Sun, Apr 20, 2003 at 01:27:24AM -0700, David Schultz wrote: > > > > If you would like to revise this patch, I would be happy to help > > > you get it committed. You might also want to take a look at > > > style(9). > > At a glance, just the whitespace around = and ==. Look more closely. There are style bugs on at least 7 of the 12 lines of the part of the patch that you quoted, and printf format errors on machines where dev_t isn't compatible with u_int... Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030420204940.N19972>