Date: Wed, 14 Aug 2019 19:55:02 +0200 From: Niclas Zeising <zeising@freebsd.org> To: Emmanuel Vadot <manu@bidouilliste.com>, John Baldwin <jhb@FreeBSD.org> Cc: x11@FreeBSD.org, current@FreeBSD.org, Ian Lepore <ian@freebsd.org> Subject: Re: HEADSUP: drm-current-kmod now installs sources Message-ID: <c9ade020-92b3-2f78-ddbb-2182ea4b41d2@freebsd.org> In-Reply-To: <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <bee728a59abb033657a20de4e716698fb2b1c927.camel@freebsd.org> <b2951cc6-e5e8-6c14-6368-41d51f949011@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <c3a3eb30-584f-a5f1-18f7-b94a45d20dd7@FreeBSD.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-08-14 19:23, Emmanuel Vadot wrote:
> On Wed, 14 Aug 2019 10:13:48 -0700
> John Baldwin <jhb@FreeBSD.org> wrote:
>
>> On 8/14/19 9:22 AM, Ian Lepore wrote:
>>> This all sounds vaguely wrong, backwards, to me. A developer who is
>>> using a given module on their build system might want that module to be
>>> rebuilt automatically, but only if the build parameters match those of
>>> the running build host system.
>>>
>>> If my build host is running freebsd 12 amd64 and I'm doing a build for
>>> freebsd 13 armv7, I have no interest in automatic rebuilds of an amd64
>>> driver module for a different OS arch and version just because that
>>> module happens to be installed on the system I use to do crossbuilds.
>>>
>>> My objections are theoretical... this automation just seems improperly
>>> designed to me. But it won't actually affect me in any way, because I
>>> don't build video driver modules from ports, and I don't run freebsd
>>> current on my build host machine. Probably the number of people doing
>>> crossbuilding is small enough that nobody else is going to object to
>>> this "the whole world is amd64" automation.
>>
>> You assume DRM is amd64-only when it is definitely not. It also has
>> suitable guards in its Makefile to only build the relevant kernel
>> modules on supported architectures.
>
> I clearly don't want to spend time to build the drm and radeon modules
> when I'm hacking on arm64.
> Shouldn't LOCAL_MODULE have ${TARGET}.${TARGET_ARCH} as a
> subdirectory ? So when you install drm-kmod-* it will only install the
> source in /usr/local/modules/${TARGET}.${TARGET_ARCH}/ ? (or whatever
> the correct dir is).
>
I'm not sure what you're trying to accomplish. I might be
misunderstanding completely, but, at least the drm ports have safeguards
in their makefiles so they'll only be built for those arches where there
is support, and only the modules needed, as an example, i915kms.ko will
only be built on amd64 and i386, if that's what you're worried about.
Regards
--
Niclas Zeising
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c9ade020-92b3-2f78-ddbb-2182ea4b41d2>