Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Mar 2001 15:39:51 -0800 (PST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, Dag-Erling Smorgrav <des@FreeBSD.org>
Subject:   RE: cvs commit: src/sys/i386/linux linux_machdep.c
Message-ID:  <XFMail.010311153951.jhb@FreeBSD.org>
In-Reply-To: <XFMail.010311153213.jhb@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 11-Mar-01 John Baldwin wrote:
> 
> On 11-Mar-01 Dag-Erling Smorgrav wrote:
>> des         2001/03/11 10:52:11 PST
>> 
>>   Modified files:
>>     sys/i386/linux       linux_machdep.c 
>>   Log:
>>   rfork() masks RFSTOPPED out of the flags it passes to fork1(), so we have
>>   to call fork1() directly if we don't want out process queued right away.
>>   This has the serendipitous side effect of saving us a call to pfind().
>>   
>>   This makes threaded Linux apps (such as Opera) work again.
> 
> ... and breaks linux thread since we can send the wrong signal to them when
> we
> exit if enough bad things happen at the wrong times.  After looking at
> rfork()
> which just calls fork1(), the proper fix would be to just call fork1() here,
> not back it all out.

And I should read diffs before sending mail so fast.  The +4 -8 was deceptive.
This patch should be applied to the alpha, too.

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010311153951.jhb>